Flexible responses #47

jpollock · 2021-08-30T04:26:11Z

No description provided.

Serverless migration

…minating); although more work needed

… can be kept separate

lightbend-cla-validator · 2021-08-30T04:26:12Z

Hi @jpollock,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator · 2021-08-30T04:26:12Z

Hi @jpollock,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

marcellanz · 2021-08-30T05:00:39Z

Awesome @jpollock ! great to see contributions to the python user language support for Cloudstate.

With changes seen like
pip install -U akkaserverless

I wonder what the story is about that PR. Shouldn't it be made on the lightbend/lightbend-labs organization instead of here at the Cloudstate repository? This PR transforms a user language support library for cloudstate into a Akka Serverless (AS) SDK compatible with the AS protocol of some of the later beta releases and is incompatible with this project here.

I think it would be better to fork/import this repository into one of these organizations instead of transforming it here. The Github UI lets you import an existing repository while keeping the git history.

marcellanz · 2021-08-30T05:07:39Z

CONTRIBUTORS.md

@@ -0,0 +1,10 @@
+# Contributors
+
+## Special thanks for all the people who had helped this project so far:


Thanks for keeping a Contributors list while migrating this to AS.

marcellanz · 2021-08-30T05:25:19Z

Description.md

-* **Key-Value storage**
-* **P2P messaging**
-* **CQRS read side projections**
+The Akka Serverless Python user language support is a library that implements the Akka Serverless protocol and offers an pythonistic API 


Suggested change

The Akka Serverless Python user language support is a library that implements the Akka Serverless protocol and offers an pythonistic API

The Akka Serverless Python SDK is a library that implements the Akka Serverless protocol and offers a pythonistic API

User Language Support Library is old Cloudstate speak I think.

Yes, Akka Serverless is using SDK.

pvlugter

I wonder what the story is about that PR. Shouldn't it be made on the lightbend/lightbend-labs organization instead of here at the Cloudstate repository?

Yes. I expect that's the plan.

pvlugter · 2021-08-30T05:27:16Z

Description.md

-* **Key-Value storage**
-* **P2P messaging**
-* **CQRS read side projections**
+The Akka Serverless Python user language support is a library that implements the Akka Serverless protocol and offers an pythonistic API 


Yes, Akka Serverless is using SDK.

pvlugter · 2021-08-30T05:29:11Z

README.md

+For more information see the documentation for [implementing Akka Serverless services in JavaScript](https://developer.lightbend.com/docs/akka-serverless/javascript/).
+
+
+This package is a fork of the original [Python SDK](https://github.com/cloudstateio/python-support) for [Cloudstate](https://cloudstate.io/). This Akka Serverless package is heavily indebted to the [C]loudstate contributors](https://github.com/cloudstateio/python-support/graphs/contributors), especially [Adriano Santos](https://github.com/sleipnir) and [Marcel Lanz](https://github.com/marcellanz).


Suggested change

This package is a fork of the original [Python SDK](https://github.com/cloudstateio/python-support) for [Cloudstate](https://cloudstate.io/). This Akka Serverless package is heavily indebted to the [C]loudstate contributors](https://github.com/cloudstateio/python-support/graphs/contributors), especially [Adriano Santos](https://github.com/sleipnir) and [Marcel Lanz](https://github.com/marcellanz).

This package is a fork of the original [Python SDK](https://github.com/cloudstateio/python-support) for [Cloudstate](https://cloudstate.io/). This Akka Serverless package is heavily indebted to the [Cloudstate contributors](https://github.com/cloudstateio/python-support/graphs/contributors), especially [Adriano Santos](https://github.com/sleipnir) and [Marcel Lanz](https://github.com/marcellanz).

pvlugter · 2021-08-30T05:29:54Z

akkaserverless/config.4,txt

+get roadmap -
+eng discussion 
+
+moving - 


@jpollock, realise this PR is not being merged here, but this looks accidental. The config.3.txt and config.4,txt files seem odd here anyway.

marcellanz · 2021-08-30T07:19:26Z

setup.py

    license="Apache 2.0",
-    description="Cloudstate Python Support Library",
+    description="Akka Serverless Python Support Library",


Suggested change

description="Akka Serverless Python Support Library",

description="Akka Serverless Python SDK",

marcellanz · 2021-08-30T07:21:29Z

setup.cfg

@@ -9,9 +9,11 @@ classifiers =
    Operating System :: OS Independent
    Programming Language :: Python
    Programming Language :: Python :: 3.6
+long_description = file: READ.md


Suggested change

long_description = file: READ.md

long_description = file: README.md

marcellanz · 2021-08-30T07:22:59Z

setup.cfg

 project_urls =
-    Documentation = https://cloudstate.io/docs/user/lang/index.html
-    Source = https://github.com/cloudstateio/python-support
+    Documentation = https://akkaserverless.io/docs/user/lang/index.html


There might be a reason to mix akkaserverless.io (here) and akkaserverless.com (at url) from time to time; or not.

marcellanz · 2021-08-30T07:28:04Z

README.md

+For more information see the documentation for [implementing Akka Serverless services in JavaScript](https://developer.lightbend.com/docs/akka-serverless/javascript/).
+
+
+This package is a fork of the original [Python SDK](https://github.com/cloudstateio/python-support) for [Cloudstate](https://cloudstate.io/). This Akka Serverless package is heavily indebted to the [C]loudstate contributors](https://github.com/cloudstateio/python-support/graphs/contributors), especially [Adriano Santos](https://github.com/sleipnir) and [Marcel Lanz](https://github.com/marcellanz).


Suggested change

This package is a fork of the original [Python SDK](https://github.com/cloudstateio/python-support) for [Cloudstate](https://cloudstate.io/). This Akka Serverless package is heavily indebted to the [C]loudstate contributors](https://github.com/cloudstateio/python-support/graphs/contributors), especially [Adriano Santos](https://github.com/sleipnir) and [Marcel Lanz](https://github.com/marcellanz).

This package is a fork of the original [User Language Support for Python](https://github.com/cloudstateio/python-support) for [Cloudstate](https://cloudstate.io/). This Akka Serverless package is heavily indebted to the [C]loudstate contributors](https://github.com/cloudstateio/python-support/graphs/contributors), especially [Adriano Santos](https://github.com/sleipnir) and [Marcel Lanz](https://github.com/marcellanz).

marcellanz · 2021-08-30T07:29:33Z

akkaserverless/akkaserverless_service.py

+
+    def host(self, address: str):
+        """Set the address of the network Host.
+        Default Address is 127.0.0.1.


on line https://github.com/cloudstateio/python-support/pull/47/files#diff-296ae8741e7ca1d6af23a82352bc2fa1814a916d2841f3c30179550c52b1b4c9R40 it defaults to 0.0.0.0.

marcellanz · 2021-08-30T07:33:15Z

akkaserverless/akkaserverless_service.py

+
+    def max_workers(self, workers: Optional[int] = multiprocessing.cpu_count()):
+        """Set the gRPC Server number of Workers.
+        Default is equal to the number of CPU Cores in the machine.


In Serverless there is no machine anymore.

marcellanz · 2021-08-30T07:38:08Z

akkaserverless/akkaserverless_service.py

+
+
+    def start(self):
+        """Start the user function and gRPC Server."""


Don't you start components in AS, instead of user functions?

sleipnir · 2021-08-30T12:30:17Z

Awesome @jpollock ! great to see contributions to the python user language support for Cloudstate.

With changes seen like
pip install -U akkaserverless

I wonder what the story is about that PR. Shouldn't it be made on the lightbend/lightbend-labs organization instead of here at the Cloudstate repository? This PR transforms a user language support library for cloudstate into a Akka Serverless (AS) SDK compatible with the AS protocol of some of the later beta releases and is incompatible with this project here.

I think it would be better to fork/import this repository into one of these organizations instead of transforming it here. The Github UI lets you import an existing repository while keeping the git history.

I completely agree with Marcel.
It just shouldn't be here.

sleipnir · 2021-08-30T12:43:42Z

Thank you @jpollock for the PR but we do not have a history discussed between LB and the CloudState community that allows them to be literally incorporated into Cloudstate, especially in terms of name and evolution of the protocol.
This should be a fork of the original and republished under the management of LB repositories.

We have an issue that treats under the issue of the evolution of the CloudState protocol but LB responded that at the moment has no interest in evolving with Cloudstate. In these terms we do not have, in my opinion, how to accept this PR fully here. This should be fork it under aegis of LB.

jpollock · 2021-08-30T13:07:48Z

Sorry! So so sorry!!!!

This was my bad. It was late at night and I intended to update my fork of this SDK: https://github.com/jpollock/akkaserverless-python-sdk.

I am beyond embarrassed that you spent time on this. I thought that I had checked the open PRs last night to confirm that my mistake was not what I thought it was but then woke this morning to see this comment chain. Ack. Again, my sincerest apologies for the confusion and wasted time.

marcellanz · 2021-08-30T13:15:48Z

@jpollock no worries.

and wasted time.

not all was wasted, there are some real comments to be used :)

marcellanz · 2021-08-30T13:34:17Z

@jpollock Also, I knew you at LB have higher standards for a PR. So after reading the PR it came to me that this might be accidental.

Jeremy Pollock and others added 17 commits August 9, 2021 16:11

initial commit for migration to akka serverless

245951a

initial value entity and view support

7699deb

removing google proto

2fc1e57

removing akka serverless proto

ca107d7

cleanup

f070eab

adding requirements

a8f5888

preparing for build

16a3cc7

Merge pull request #1 from jpollock/serverless_migration

925cb8c

Serverless migration

updating to account for akka serverless protocol apis (health and ter…

d56e3d8

…minating); although more work needed

addressing some action requirements

1dbe51c

getting read for initial release

ca548f1

getting read for initial release

2ea6742

cleaning up some release issues

2baab76

updating proxy protocol version

47df2b4

getting ready for first prod release

0a0e842

removing health check meaningless logging

4874748

first pass at solving the issue such that state and function response…

62c6cc9

… can be kept separate

marcellanz requested review from sleipnir and pvlugter August 30, 2021 05:03

marcellanz reviewed Aug 30, 2021

View reviewed changes

pvlugter reviewed Aug 30, 2021

View reviewed changes

marcellanz reviewed Aug 30, 2021

View reviewed changes

jpollock closed this Aug 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flexible responses #47

Flexible responses #47

jpollock commented Aug 30, 2021

lightbend-cla-validator commented Aug 30, 2021

lightbend-cla-validator commented Aug 30, 2021

marcellanz commented Aug 30, 2021

marcellanz Aug 30, 2021

marcellanz Aug 30, 2021 •

edited by pvlugter

Loading

pvlugter Aug 30, 2021

pvlugter left a comment

pvlugter Aug 30, 2021

pvlugter Aug 30, 2021

pvlugter Aug 30, 2021 •

edited

Loading

marcellanz Aug 30, 2021

marcellanz Aug 30, 2021

marcellanz Aug 30, 2021

marcellanz Aug 30, 2021

marcellanz Aug 30, 2021

marcellanz Aug 30, 2021

marcellanz Aug 30, 2021

sleipnir commented Aug 30, 2021

sleipnir commented Aug 30, 2021

jpollock commented Aug 30, 2021

marcellanz commented Aug 30, 2021

marcellanz commented Aug 30, 2021

		@@ -0,0 +1,10 @@
		# Contributors

		## Special thanks for all the people who had helped this project so far:

	The Akka Serverless Python user language support is a library that implements the Akka Serverless protocol and offers an pythonistic API
	The Akka Serverless Python SDK is a library that implements the Akka Serverless protocol and offers a pythonistic API

		For more information see the documentation for [implementing Akka Serverless services in JavaScript](https://developer.lightbend.com/docs/akka-serverless/javascript/).


		This package is a fork of the original [Python SDK](https://github.com/cloudstateio/python-support) for [Cloudstate](https://cloudstate.io/). This Akka Serverless package is heavily indebted to the [C]loudstate contributors](https://github.com/cloudstateio/python-support/graphs/contributors), especially [Adriano Santos](https://github.com/sleipnir) and [Marcel Lanz](https://github.com/marcellanz).

	description="Akka Serverless Python Support Library",
	description="Akka Serverless Python SDK",

	long_description = file: READ.md
	long_description = file: README.md



		def start(self):
		"""Start the user function and gRPC Server."""

Flexible responses #47

Flexible responses #47

Conversation

jpollock commented Aug 30, 2021

lightbend-cla-validator commented Aug 30, 2021

lightbend-cla-validator commented Aug 30, 2021

marcellanz commented Aug 30, 2021

Choose a reason for hiding this comment

marcellanz Aug 30, 2021 • edited by pvlugter Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pvlugter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pvlugter Aug 30, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sleipnir commented Aug 30, 2021

sleipnir commented Aug 30, 2021

jpollock commented Aug 30, 2021

marcellanz commented Aug 30, 2021

marcellanz commented Aug 30, 2021

marcellanz Aug 30, 2021 •

edited by pvlugter

Loading

pvlugter Aug 30, 2021 •

edited

Loading