-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat(tool): add template render subcommand using .tpl #1430
Open
ShawnJeffersonWang
wants to merge
45
commits into
cloudwego:develop
Choose a base branch
from
ShawnJeffersonWang:dev
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
DMwangnima
reviewed
Jul 12, 2024
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/new_custom_template #1430 +/- ##
===========================================================
Coverage ? 70.40%
===========================================================
Files ? 292
Lines ? 21032
Branches ? 0
===========================================================
Hits ? 14808
Misses ? 4994
Partials ? 1230 ☔ View full report in Codecov by Sentry. |
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
also: fix(server): invoker return err if no apache codec fix(server): listening on loopback addr
…o#1427) # Conflicts: # pkg/protocol/bthrift/binary.go
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]> fix: fix some issue Signed-off-by: shawn <[email protected]> perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) # Conflicts: # internal/generic/thrift/http_fallback.go # pkg/protocol/bthrift/binary.go # pkg/rpcinfo/rpcconfig.go # pkg/rpcinfo/rpcconfig_test.go # tool/cmd/kitex/args/tpl_args.go # tool/cmd/kitex/main.go # tool/internal_pkg/generator/generator.go # tool/internal_pkg/pluginmode/thriftgo/plugin.go # tool/internal_pkg/util/command.go
Signed-off-by: shawn <[email protected]> bug fixes: fix bug in generator_test Signed-off-by: shawn <[email protected]> bug fixes: add gen-path Signed-off-by: shawn <[email protected]> bug fixes: treat option as unknown command Signed-off-by: shawn <[email protected]> bug fix: fix unused code in command and flag Signed-off-by: shawn <[email protected]> bug fixes: fix lint Signed-off-by: shawn <[email protected]> fix: use gofumpt -extra to fix golanci lint Signed-off-by: shawn <[email protected]> fix: use gofumpt to avoid golangci lint Signed-off-by: shawn <[email protected]> add InitType perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) fix: fix a bug "unknown service xxx" when using CombineService client by not writing IDLServiceName and searching serviceInfo by method name (cloudwego#1402) fix: support setting PurePayload with new style (cloudwego#1438) refactor(multi-services): refactoring service and method routing for multi-services (cloudwego#1439) refactor: move apache code to separated pkg (cloudwego#1381) Co-authored-by: QihengZhou <[email protected]> Co-authored-by: Yi Duan <[email protected]> refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly (cloudwego#1408) chore: upgrade go directive version to 1.17 of go.mod (cloudwego#1415) refactor: get rid of apache TApplicationException (cloudwego#1389) feat(generic): support grpc json generic for client (cloudwego#1411) feat: add PrependError for thriftgo (cloudwego#1420) feat(thrift): generic fastcodec (cloudwego#1424) feat(tool): no apache for fastcodec (cloudwego#1426) * use bthrift.PrependError * updated kitex tool MinDepVersion to 0.11.0 * fixed `undefined: bthrift.KitexUnusedProtection` chore: fixed undefined KitexUnusedProtection (cloudwego#1428) test: works without apache code (cloudwego#1429) chore: update CI version and readme community (cloudwego#1431) refactor: new generic interface without thrift apache (cloudwego#1434) fix(generic): fix payload length check for http generic (cloudwego#1442) chore: pick and fix conflict commits from develop branch (cloudwego#1457) Co-authored-by: Jayant <[email protected]> chore: update dependency (cloudwego#1447) chore(ci): disable cache for lint and staticchecks (cloudwego#1451) refactor(test): perf optimize and log loc correct (cloudwego#1455) chore(ci): speed up multiple ci processes 8min -> 1min (cloudwego#1454) * rm unused codeconv, it didn't work as expected due to quota and user experience * don't use cache for self-hosted runners * cache for github hosted runners hotfix: multi service registry issue chore(ci): optimized bench tests. it takes <1m now (cloudwego#1461) chore(test): fix xorshift64 in consist_test.go (cloudwego#1462) chore: fix grpc keepalive test by start server responsiblly (cloudwego#1463) refactor: deprecate bthrift, use cloudwego/gopkg (cloudwego#1441) * tool: generates code for using cloudwego/gopkg * internal/mocks: updated thrift using the latest tool * pkg/utils/fastthrift: moved to cloudwego/gopkg * pkg/remote/codec/thrift: uses skipdecoder of cloudwego/gopkg * pkg/remote/codec/thrift: add fastcodec as a fallback, and always use fastcodec for Ex * pkg/generic: uses cloudwego/gopkg for pkg/protocol/bthrift: * type BinaryWriter = gopkgthrift.NocopyWriter * Removed ThriftFastCodec, moved to cloudwego/gopkg before releasing * Removed bthrift/exception.go, moved to cloudwego/gopkg before releasing * Removed bthrift/test, only for unknownfields testing * bthrift/unknown: moved to cloudwego/gopkg refactor(generic): remove apache thrift.TProtocol from generic (cloudwego#1450)
add test for command and flag resolve conflicts refactor: rm apache thrift in pkg/generic & netpollmux (cloudwego#1470) fix: allow HEADERS frame with empty header block fragment (cloudwego#1466) refactor: rm apache thrift in internal/mocks (cloudwego#1474) also: fix(server): invoker return err if no apache codec fix(server): listening on loopback addr chore: remove github.com/stretchr/testify direct dependency (cloudwego#1475) chore: upgrade gopkg to v0.1.0 (cloudwego#1477) perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) # Conflicts: # pkg/protocol/bthrift/binary.go resolve conflicts feat: add init Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]> feat: add subcommand clean Signed-off-by: shawn <[email protected]> feat: add kitex_render_meta.yaml for render Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]> chore(generic): add generic base using gopkg base (cloudwego#1482) fix(gonet): adjust gonet server read timeout to avoid read error (cloudwego#1481) fix: remove redundant line Signed-off-by: shawn <[email protected]> fix: fix single command Signed-off-by: shawn <[email protected]> feat: add userDefinedMiddleware Signed-off-by: shawn <[email protected]>
683bf1c
to
4e4e8de
Compare
Signed-off-by: shawn <[email protected]>
Signed-off-by: shawn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
feat(工具):支持template render子命令根据.tpl文件渲染生成模板文件
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
How to use
kitex template render ${tpl dir} -module ${module} xxx.thrift