New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(streamv2): support ttheader streaming #1541

Merged

joway merged 34 commits into develop from feat/ttstream-v2

Nov 28, 2024

Member

joway commented Sep 11, 2024 •

edited

Loading

What type of PR is this?

feat

Check the PR title.

This PR title match the format: <type>(optional scope): <description>
The description of this PR title is user-oriented and clear enough for others to understand.
Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

joway requested review from a team as code owners

September 11, 2024 06:36

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment

license-eye has totally checked 693 files.

Valid	Invalid	Ignored	Fixed
618	46	29	0

Click to see the invalid file list

client/streamxclient/streamxcallopt/call_option.go
client/streamxclient/client.go
client/streamxclient/client_gen.go
client/streamxclient/client_option.go
client/client_streamx.go
pkg/streamx/provider/jsonrpc/client_option.go
pkg/streamx/provider/jsonrpc/client_provier.go
pkg/streamx/provider/jsonrpc/jsonrpc_gen_test.go
pkg/streamx/provider/jsonrpc/jsonrpc_impl_test.go
pkg/streamx/provider/jsonrpc/jsonrpc_test.go
pkg/streamx/provider/jsonrpc/metadata.go
pkg/streamx/provider/jsonrpc/protocol.go
pkg/streamx/provider/jsonrpc/server_option.go
pkg/streamx/provider/jsonrpc/server_provider.go
pkg/streamx/provider/jsonrpc/stream.go
pkg/streamx/provider/jsonrpc/transport.go
pkg/streamx/provider/jsonrpc/transport_test.go
pkg/streamx/provider/ttstream/client_option.go
pkg/streamx/provider/ttstream/client_provier.go
pkg/streamx/provider/ttstream/client_trans_pool.go
pkg/streamx/provider/ttstream/frame.go
pkg/streamx/provider/ttstream/frame_test.go
pkg/streamx/provider/ttstream/metadata.go
pkg/streamx/provider/ttstream/mock_test.go
pkg/streamx/provider/ttstream/server_option.go
pkg/streamx/provider/ttstream/server_provider.go
pkg/streamx/provider/ttstream/stream.go
pkg/streamx/provider/ttstream/stream_io.go
pkg/streamx/provider/ttstream/stream_metadata.go
pkg/streamx/provider/ttstream/transport.go
pkg/streamx/provider/ttstream/transport_test.go
pkg/streamx/provider/ttstream/ttstream_client_test.go
pkg/streamx/provider/ttstream/ttstream_common_test.go
pkg/streamx/provider/ttstream/ttstream_gen_codec_test.go
pkg/streamx/provider/ttstream/ttstream_gen_service_test.go
pkg/streamx/provider/ttstream/ttstream_server_test.go
pkg/streamx/client_provider.go
pkg/streamx/client_provider_internal.go
pkg/streamx/server_provider.go
pkg/streamx/server_provider_internal.go
pkg/streamx/stream.go
pkg/streamx/stream_args.go
pkg/streamx/stream_middleware.go
server/streamxserver/server.go
server/streamxserver/server_gen.go
server/streamxserver/server_option.go

joway force-pushed the feat/ttstream-v2 branch 4 times, most recently from 09a8cf7 to ac990a5 Compare

September 16, 2024 09:39

joway force-pushed the feat/ttstream-v2 branch 11 times, most recently from 39ffc25 to 1d20e07 Compare

September 27, 2024 09:33

joway force-pushed the feat/ttstream-v2 branch from 3ccd7b0 to e95b634 Compare

October 10, 2024 03:39

github-advanced-security bot found potential problems

View reviewed changes

pkg/transmeta/ttheader.go Fixed Show fixed Hide fixed

pkg/transmeta/ttheader.go Fixed Show fixed Hide fixed

joway force-pushed the feat/ttstream-v2 branch from 5279a09 to 4873336 Compare

October 14, 2024 08:11

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment

license-eye has totally checked 722 files.

Valid	Invalid	Ignored	Fixed
677	18	27	0

Click to see the invalid file list

client/streamxclient/streamxcallopt/call_option.go
client/streamxclient/client.go
client/streamxclient/client_gen.go
client/streamxclient/client_option.go
client/client_streamx.go
pkg/streamx/provider/ttstream/container/object_pool.go
pkg/streamx/provider/ttstream/container/stack_test.go
pkg/streamx/provider/ttstream/exception.go
pkg/streamx/provider/ttstream/ttstream_error_test.go
pkg/streamx/client_options.go
pkg/streamx/header_trailer.go
server/streamxserver/server.go
server/streamxserver/server_gen.go
server/streamxserver/server_option.go
tool/internal_pkg/tpl/streamx/client.go
tool/internal_pkg/tpl/streamx/handler.method.go
tool/internal_pkg/tpl/streamx/server.go
tool/internal_pkg/tpl/streamx/service.go

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment

license-eye has totally checked 723 files.

Valid	Invalid	Ignored	Fixed
677	19	27	0

Click to see the invalid file list

client/streamxclient/streamxcallopt/call_option.go
client/streamxclient/client.go
client/streamxclient/client_gen.go
client/streamxclient/client_option.go
client/client_streamx.go
pkg/streamx/provider/ttstream/container/object_pool.go
pkg/streamx/provider/ttstream/container/stack_test.go
pkg/streamx/provider/ttstream/exception.go
pkg/streamx/provider/ttstream/ttstream_error_test.go
pkg/streamx/client_options.go
pkg/streamx/header_trailer.go
pkg/streamx/stream_middleware_internal.go
server/streamxserver/server.go
server/streamxserver/server_gen.go
server/streamxserver/server_option.go
tool/internal_pkg/tpl/streamx/client.go
tool/internal_pkg/tpl/streamx/handler.method.go
tool/internal_pkg/tpl/streamx/server.go
tool/internal_pkg/tpl/streamx/service.go

joway force-pushed the feat/ttstream-v2 branch from 19781a5 to 2bdb54d Compare

October 14, 2024 08:39

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment

license-eye has totally checked 723 files.

Valid	Invalid	Ignored	Fixed
677	19	27	0

Click to see the invalid file list

client/streamxclient/streamxcallopt/call_option.go
client/streamxclient/client.go
client/streamxclient/client_gen.go
client/streamxclient/client_option.go
client/client_streamx.go
pkg/streamx/provider/ttstream/container/object_pool.go
pkg/streamx/provider/ttstream/container/stack_test.go
pkg/streamx/provider/ttstream/exception.go
pkg/streamx/provider/ttstream/ttstream_error_test.go
pkg/streamx/client_options.go
pkg/streamx/header_trailer.go
pkg/streamx/stream_middleware_internal.go
server/streamxserver/server.go
server/streamxserver/server_gen.go
server/streamxserver/server_option.go
tool/internal_pkg/tpl/streamx/client.go
tool/internal_pkg/tpl/streamx/handler.method.go
tool/internal_pkg/tpl/streamx/server.go
tool/internal_pkg/tpl/streamx/service.go

joway force-pushed the feat/ttstream-v2 branch from 2bdb54d to fe7f8cd Compare

October 14, 2024 08:41

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment

license-eye has totally checked 723 files.

Valid	Invalid	Ignored	Fixed
677	19	27	0

Click to see the invalid file list

client/streamxclient/streamxcallopt/call_option.go
client/streamxclient/client.go
client/streamxclient/client_gen.go
client/streamxclient/client_option.go
client/client_streamx.go
pkg/streamx/provider/ttstream/container/object_pool.go
pkg/streamx/provider/ttstream/container/stack_test.go
pkg/streamx/provider/ttstream/exception.go
pkg/streamx/provider/ttstream/ttstream_error_test.go
pkg/streamx/client_options.go
pkg/streamx/header_trailer.go
pkg/streamx/stream_middleware_internal.go
server/streamxserver/server.go
server/streamxserver/server_gen.go
server/streamxserver/server_option.go
tool/internal_pkg/tpl/streamx/client.go
tool/internal_pkg/tpl/streamx/handler.method.go
tool/internal_pkg/tpl/streamx/server.go
tool/internal_pkg/tpl/streamx/service.go

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment

license-eye has totally checked 722 files.

Valid	Invalid	Ignored	Fixed
676	19	27	0

Click to see the invalid file list

client/streamxclient/streamxcallopt/call_option.go
client/streamxclient/client.go
client/streamxclient/client_gen.go
client/streamxclient/client_option.go
client/client_streamx.go
pkg/streamx/provider/ttstream/container/object_pool.go
pkg/streamx/provider/ttstream/container/stack_test.go
pkg/streamx/provider/ttstream/exception.go
pkg/streamx/provider/ttstream/ttstream_error_test.go
pkg/streamx/client_options.go
pkg/streamx/header_trailer.go
pkg/streamx/stream_middleware_internal.go
server/streamxserver/server.go
server/streamxserver/server_gen.go
server/streamxserver/server_option.go
tool/internal_pkg/tpl/streamx/client.go
tool/internal_pkg/tpl/streamx/handler.method.go
tool/internal_pkg/tpl/streamx/server.go
tool/internal_pkg/tpl/streamx/service.go

joway changed the title ~~WIP: feat(streamv2): support ttheader streaming~~ feat(streamv2): support ttheader streaming

DMwangnima and others added 22 commits

November 28, 2024 14:41


          feat: support TTHeader Streaming detailed error handling (#1594)

9cd6906


          refactor: stream transport layer (#1600)

74c33ec


          chore: using thrift payload mock

68574c1


          chore: add transport buffer test (#1605)

de4ba2b


          feat: TTHeader Streaming errors inherit from kerrors.ErrStreamingProt…

3afbd88

…ocol (#1603)


          refactor: using new user api

8e476c5


          chore: add comments

f06ff05


          fix: mux transport leak


          chore: fix stream recv timeout test

20592bd


          chore: reduce streamx log

c742bab


          fix: start goroutine with recover

4fcf8b4


          chore: ut wait server stream done

29790d1


          fix: client StreamX API ignore req args

509060e


          feat: refactor streamx APIs (#1612)


          feat: using original trace ctx (#1613)

19cf804


          chore: fix service name and check str header and int header

9401a78


          refactor: refine streamx generation code (#1610)

694f7e9


          feat: add ttheader streaming protocol

10e5bdf


          fix: traceCtx should assgin to ctx (#1618)

e9a9750


          fix: use old client api (#1620)

dc99b5a


          fix: gen normal code in streamx mode (#1621)

b0f3a46


          refactor: rm sinfo from provider api (#1626)

c3b6729

joway force-pushed the feat/ttstream-v2 branch from 64f704e to c3b6729 Compare

November 28, 2024 06:41


          chore: using gopool

262ad85

joway dismissed YangruiEmma’s stale review via

262ad85

November 28, 2024 06:48


          chore: unexport detailed err type (#1629)

b11fc2c

DMwangnima approved these changes

View reviewed changes

YangruiEmma approved these changes

View reviewed changes

joway merged commit 9dbafca into develop

37 checks passed

joway deleted the feat/ttstream-v2 branch

November 28, 2024 07:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jayantxie jayantxie left review comments

ppzqh ppzqh left review comments

github-actions[bot] github-actions[bot] left review comments

Marina-Sakai Marina-Sakai left review comments

YangruiEmma YangruiEmma approved these changes

DMwangnima DMwangnima approved these changes

Labels

None yet