bump version 0.8.0 (#187) #513
Millioneci.yaml
on: push
Matrix: lint
test-linux
57s
test-linux-aarch64
1m 41s
test-macos
1m 49s
test-windows
3m 1s
CI is green
0s
Annotations
40 warnings
|
this function has too many arguments (8/7):
pilota-build/src/lib.rs#L232
warning: this function has too many arguments (8/7)
--> pilota-build/src/lib.rs:232:5
|
232 | / pub fn build_cx(
233 | | services: Vec<IdlService>,
234 | | out: Option<Output>,
235 | | mut parser: P,
... |
240 | | keep_unknown_fields: Vec<PathBuf>,
241 | | ) -> Context {
| |________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
pilota-build/src/resolve.rs#L167
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> pilota-build/src/resolve.rs:167:13
|
167 | / match &item.kind {
168 | | ir::ItemKind::Enum(e) => e.variants.iter().for_each(|e| {
169 | | self.def_sym(Namespace::Value, (*e.name).clone());
170 | | }),
171 | | _ => {}
172 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try this
|
167 ~ if let ir::ItemKind::Enum(e) = &item.kind { e.variants.iter().for_each(|e| {
168 + self.def_sym(Namespace::Value, (*e.name).clone());
169 + }) }
|
|
|
parameter is only used in recursion:
pilota-build/src/parser/protobuf/mod.rs#L66
warning: parameter is only used in recursion
--> pilota-build/src/parser/protobuf/mod.rs:66:9
|
66 | message_name: Option<&str>,
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_message_name`
|
note: parameter used here
--> pilota-build/src/parser/protobuf/mod.rs:81:33
|
81 | ... message_name,
| ^^^^^^^^^^^^
...
87 | ... message_name,
| ^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
= note: `#[warn(clippy::only_used_in_recursion)]` on by default
|
|
unneeded `return` statement:
pilota/src/thrift/compact.rs#L1649
warning: unneeded `return` statement
--> pilota/src/thrift/compact.rs:1649:18
|
1649 | unsafe { return Ok(FastStr::from_bytes_unchecked(bytes)) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
|
if let .. else expression looks like `matches!` macro:
pilota-build/src/middle/context.rs#L347
warning: if let .. else expression looks like `matches!` macro
--> pilota-build/src/middle/context.rs:347:33
|
347 | / ... if let Some(crate::tags::KeepUnknownFields(false)) =
348 | | ... cx.db.tags_map().get(&tags).and_then(|tags| {
349 | | ... tags.get::<crate::tags::KeepUnknownFields>()
350 | | ... })
... |
354 | | ... true
355 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
= note: `#[warn(clippy::match_like_matches_macro)]` on by default
help: try this
|
347 ~ !matches!(cx.db.tags_map().get(&tags).and_then(|tags| {
348 + tags.get::<crate::tags::KeepUnknownFields>()
349 + }), Some(crate::tags::KeepUnknownFields(false)))
|
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
pilota-build/src/middle/context.rs#L336
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> pilota-build/src/middle/context.rs:336:38
|
336 | let file = files.get(&file_id).unwrap();
| ^^^^^^^^ help: change this to: `file_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
pilota-build/src/middle/context.rs#L205
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> pilota-build/src/middle/context.rs:205:62
|
205 | PathCollector { cx, set }.visit_path(&p);
| ^^ help: change this to: `p`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
pilota/src/thrift/binary_unsafe.rs#L1169
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> pilota/src/thrift/binary_unsafe.rs:1169:9
|
1169 | &mut self.trans
| ^^^^^^^^^^^^^^^ help: change this to: `self.trans`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this lifetime isn't used in the function definition:
pilota-build/src/codegen/mod.rs#L428
warning: this lifetime isn't used in the function definition
--> pilota-build/src/codegen/mod.rs:428:24
|
428 | pub fn write_items<'a>(&self, stream: &mut String, items: impl Iterator<Item = CodegenItem>)
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
= note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
|
|
unneeded `return` statement:
pilota/src/thrift/binary_unsafe.rs#L1107
warning: unneeded `return` statement
--> pilota/src/thrift/binary_unsafe.rs:1107:13
|
1107 | return Ok(FastStr::from_bytes_unchecked(bytes));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
|
use of `offset` with a `usize` casted to an `isize`:
pilota/src/thrift/binary_unsafe.rs#L738
warning: use of `offset` with a `usize` casted to an `isize`
--> pilota/src/thrift/binary_unsafe.rs:738:17
|
738 | self.buf.as_mut_ptr().offset(self.index as isize),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(self.index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
|
|
use of `offset` with a `usize` casted to an `isize`:
pilota/src/thrift/binary_unsafe.rs#L683
warning: use of `offset` with a `usize` casted to an `isize`
--> pilota/src/thrift/binary_unsafe.rs:683:17
|
683 | self.buf.as_mut_ptr().offset(self.index as isize),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(self.index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
|
|
use of `offset` with a `usize` casted to an `isize`:
pilota/src/thrift/binary_unsafe.rs#L674
warning: use of `offset` with a `usize` casted to an `isize`
--> pilota/src/thrift/binary_unsafe.rs:674:21
|
674 | self.trans.bytes_mut().as_mut_ptr().offset(l as isize),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.trans.bytes_mut().as_mut_ptr().add(l)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
|
|
use of `offset` with a `usize` casted to an `isize`:
pilota/src/thrift/binary_unsafe.rs#L653
warning: use of `offset` with a `usize` casted to an `isize`
--> pilota/src/thrift/binary_unsafe.rs:653:17
|
653 | self.buf.as_mut_ptr().offset(self.index as isize),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(self.index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
|
|
use of `offset` with a `usize` casted to an `isize`:
pilota/src/thrift/binary_unsafe.rs#L551
warning: use of `offset` with a `usize` casted to an `isize`
--> pilota/src/thrift/binary_unsafe.rs:551:17
|
551 | self.buf.as_mut_ptr().offset(self.index as isize),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(self.index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
|
|
use of `offset` with a `usize` casted to an `isize`:
pilota/src/thrift/binary_unsafe.rs#L542
warning: use of `offset` with a `usize` casted to an `isize`
--> pilota/src/thrift/binary_unsafe.rs:542:21
|
542 | self.trans.bytes_mut().as_mut_ptr().offset(l as isize),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.trans.bytes_mut().as_mut_ptr().add(l)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
|
|
use of `offset` with a `usize` casted to an `isize`:
pilota/src/thrift/binary_unsafe.rs#L448
warning: use of `offset` with a `usize` casted to an `isize`
--> pilota/src/thrift/binary_unsafe.rs:448:17
|
448 | self.buf.as_mut_ptr().offset(self.index as isize),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(self.index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
|
|
use of `offset` with a `usize` casted to an `isize`:
pilota/src/thrift/binary_unsafe.rs#L393
warning: use of `offset` with a `usize` casted to an `isize`
--> pilota/src/thrift/binary_unsafe.rs:393:17
|
393 | self.buf.as_mut_ptr().offset(self.index as isize),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(self.index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
|
|
use of `offset` with a `usize` casted to an `isize`:
pilota/src/thrift/binary_unsafe.rs#L379
warning: use of `offset` with a `usize` casted to an `isize`
--> pilota/src/thrift/binary_unsafe.rs:379:17
|
379 | self.buf.as_mut_ptr().offset(self.index as isize),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(self.index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
|
|
useless use of `format!`:
pilota-build/src/codegen/thrift/mod.rs#L673
warning: useless use of `format!`
--> pilota-build/src/codegen/thrift/mod.rs:673:33
|
673 | / ... format!(
674 | | ... r#"Err(::pilota::thrift::DecodeError::new(
675 | | ... ::pilota::thrift::DecodeErrorKind::InvalidData,
676 | | ... "received empty union from remote Message")
677 | | ... )"#
678 | | ... )
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
help: consider using `.to_string()`
|
673 ~ r#"Err(::pilota::thrift::DecodeError::new(
674 + ::pilota::thrift::DecodeErrorKind::InvalidData,
675 + "received empty union from remote Message")
676 + )"#.to_string()
|
|
|
use of `offset` with a `usize` casted to an `isize`:
pilota/src/thrift/binary_unsafe.rs#L277
warning: use of `offset` with a `usize` casted to an `isize`
--> pilota/src/thrift/binary_unsafe.rs:277:17
|
277 | self.buf.as_mut_ptr().offset(self.index as isize),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(self.index)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
= note: `#[warn(clippy::ptr_offset_with_cast)]` on by default
|
|
unneeded `return` statement:
pilota/src/thrift/binary_le.rs#L913
warning: unneeded `return` statement
--> pilota/src/thrift/binary_le.rs:913:18
|
913 | unsafe { return Ok(FastStr::from_bytes_unchecked(bytes)) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
|
writing `&mut String` instead of `&mut str` involves a new object where a slice will do:
pilota-build/src/codegen/thrift/mod.rs#L316
warning: writing `&mut String` instead of `&mut str` involves a new object where a slice will do
--> pilota-build/src/codegen/thrift/mod.rs:316:59
|
316 | fn codegen_entry_enum(&self, _def_id: DefId, _stream: &mut String, _e: &rir::Enum) {
| ^^^^^^^^^^^ help: change this to: `&mut str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
redundant closure:
pilota-build/src/codegen/workspace.rs#L120
warning: redundant closure
--> pilota-build/src/codegen/workspace.rs:120:18
|
120 | .map(|s| FastStr::new(s))
| ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `FastStr::new`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
unneeded `return` statement:
pilota/src/thrift/binary.rs#L699
warning: unneeded `return` statement
--> pilota/src/thrift/binary.rs:699:18
|
699 | unsafe { return Ok(FastStr::from_bytes_unchecked(bytes)) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
= help: remove `return`
|
|
use Vec::sort_by_key here instead:
pilota-build/src/codegen/toml.rs#L9
warning: use Vec::sort_by_key here instead
--> pilota-build/src/codegen/toml.rs:9:13
|
9 | a.sort_by(|a, b| a.to_string().cmp(&b.to_string()));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.sort_by_key(|a| a.to_string())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
= note: `#[warn(clippy::unnecessary_sort_by)]` on by default
|
|
this function has too many arguments (8/7):
pilota/src/prost/encoding.rs#L1562
warning: this function has too many arguments (8/7)
--> pilota/src/prost/encoding.rs:1562:9
|
1562 | / pub fn encode_with_default<K, V, B, KE, KL, VE, VL>(
1563 | | key_encode: KE,
1564 | | key_encoded_len: KL,
1565 | | val_encode: VE,
... |
1570 | | buf: &mut B,
1571 | | ) where
| |__________^
...
1680 | map!(BTreeMap);
| -------------- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
this function has too many arguments (8/7):
pilota/src/prost/encoding.rs#L1562
warning: this function has too many arguments (8/7)
--> pilota/src/prost/encoding.rs:1562:9
|
1562 | / pub fn encode_with_default<K, V, B, KE, KL, VE, VL>(
1563 | | key_encode: KE,
1564 | | key_encoded_len: KL,
1565 | | val_encode: VE,
... |
1570 | | buf: &mut B,
1571 | | ) where
| |__________^
...
1676 | map!(HashMap);
| ------------- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
= note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
test-linux-aarch64
This self-hosted runner is currently using runner version 2.305.0. This version is out of date. Please update to the latest version 2.307.1
|
|
test-macos
The following actions uses node12 which is deprecated and will be forced to run on node16: Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
test-macos
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-macos
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-macos
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-macos
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-linux
This self-hosted runner is currently using runner version 2.305.0. This version is out of date. Please update to the latest version 2.307.1
|
|
test-windows
The following actions uses node12 which is deprecated and will be forced to run on node16: Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
test-windows
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-windows
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-windows
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-windows
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|