fix(pilota-build): empty union (#194)

cloudwego · Sep 25, 2023 · 541ffb0 · 541ffb0
1 parent c0564bb
commit 541ffb0
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 8 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/pilota-build/Cargo.toml b/pilota-build/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "pilota-build"
-version = "0.8.3"
+version = "0.8.4"
 edition = "2021"
 description = "Compile thrift and protobuf idl into rust code at compile-time."
 documentation = "https://docs.rs/pilota-build"

diff --git a/pilota-build/src/codegen/thrift/mod.rs b/pilota-build/src/codegen/thrift/mod.rs
@@ -577,12 +577,20 @@ impl CodegenBackend for ThriftBackend {
                         protocol.write_struct_end()?;
                         Ok(())"#
                     },
-                    format! {
-                        r#"protocol.struct_begin_len(&::pilota::thrift::TStructIdentifier {{
-                            name: "{name_str}",
-                        }}) + match self {{
-                            {variants_size}
-                        }} +  protocol.field_stop_len() + protocol.struct_end_len()"#
+                    if !e.variants.is_empty() {
+                        format! {
+                            r#"protocol.struct_begin_len(&::pilota::thrift::TStructIdentifier {{
+                                name: "{name_str}",
+                            }}) + match self {{
+                                {variants_size}
+                            }} +  protocol.field_stop_len() + protocol.struct_end_len()"#
+                        }
+                    } else {
+                        format! {
+                            r#"protocol.struct_begin_len(&::pilota::thrift::TStructIdentifier {{
+                                name: "{name_str}",
+                            }}) + protocol.field_stop_len() + protocol.struct_end_len()"#
+                        }
                     },
                     |helper| {
                         let record_ptr = if keep && !helper.is_async {