Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing i8 type #183

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix: missing i8 type #183

merged 1 commit into from
Oct 27, 2023

Conversation

junhaideng
Copy link
Contributor

Motivation

pilota build failed

struct Number {
    1: optional i8 a = 0; 
}
 thread 'main' panicked at 'unexpected literal Int(0) with ty I8', .../rsproxy.cn-8f6827c7555bfaf8/pilota-build-0.7.7/src/middle/context.rs:678:18

Solution

code gen i8 type

@junhaideng junhaideng requested review from a team as code owners July 24, 2023 02:08
@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

@PureWhiteWu
Copy link
Member

Seems that there's no i8 type in the thrift types doc: https://thrift.apache.org/docs/types

@PureWhiteWu PureWhiteWu enabled auto-merge (squash) October 27, 2023 05:53
@PureWhiteWu PureWhiteWu merged commit 392993b into cloudwego:main Oct 27, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants