feat: Support thrift uuid type #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWhiteWu
previously approved these changes
Oct 7, 2023
my-vegetable-has-exploded
force-pushed
the
uuid
branch
from
157a756
to
e88b793
Compare
my-vegetable-has-exploded
force-pushed
the
uuid
branch
from
e88b793
to
16cfc88
Compare
|
I remember the bench for unknown use the Message struct, maybe you should fix that either? https://github.com/cloudwego/pilota/blob/main/pilota-build/benches/unknown.rs#L148 |
Sorry, I didn't notice it. Empty uid have been added. |
Millione
approved these changes
Oct 11, 2023
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
add uuid type for thrift
Solution
add uuid type ([u8; 16] in rust) for parser 、 resolver and codegen.
close #58