feat: generate enum default as newtype #233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, thrift/protobuf enum type is generated to rust enum type by default, and we provided an annotation
pilota.enum_mode="new_type"
for users to change the rust generated type to a wrapper of i32. Over time, we found that it is more correct to make the newtype the default behaviour, as when users add a new variant in the enum definition, it will not cause the old idl generated code to fail to decode.Solution
Deprecate annotation
pilota.enum_mode="new_type"
and make it as default behaviour.Generated: