Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pilota_build): idl enum should implement the From<NewType> trait for inner type #235

Merged
merged 2 commits into from
Apr 1, 2024
Merged

fix(pilota_build): idl enum should implement the From<NewType> trait for inner type #235

merged 2 commits into from
Apr 1, 2024

Conversation

Ggiggle
Copy link
Contributor

@Ggiggle Ggiggle commented Apr 1, 2024

Motivation

The generated new type for idl enum type would encounter the encoding error for the lack of implementation of into inner trait.

Solution

Implement the From trait for Inner type when generate the idl enum type.

@Ggiggle Ggiggle requested review from a team as code owners April 1, 2024 04:43
@Ggiggle Ggiggle merged commit 5399e58 into main Apr 1, 2024
11 checks passed
@Ggiggle Ggiggle deleted the fix/enum_into_inner branch April 1, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Millione Millione Millione approved these changes

@PureWhiteWu PureWhiteWu PureWhiteWu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ggiggle @PureWhiteWu @Millione