Skip to content

fix: use var_{id} as local variable name to avoid the name conflict w… #723

fix: use var_{id} as local variable name to avoid the name conflict w…

fix: use var_{id} as local variable name to avoid the name conflict w… #723

GitHub Actions / clippy succeeded Sep 18, 2024 in 1s

clippy

17 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 17
Note 0
Help 0

Versions

  • rustc 1.83.0-nightly (28e8f01c2 2024-09-17)
  • cargo 1.83.0-nightly (a9a418d1a 2024-09-15)
  • clippy 0.1.82 (28e8f01 2024-09-17)

Annotations

Check warning on line 60 in pilota-build/src/ir/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct `ExceptionVariant` is never constructed

warning: struct `ExceptionVariant` is never constructed
  --> pilota-build/src/ir/mod.rs:60:12
   |
60 | pub struct ExceptionVariant {
   |            ^^^^^^^^^^^^^^^^
   |
   = note: `ExceptionVariant` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

Check warning on line 14 in pilota-build/src/index.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `increment_by` is never used

warning: method `increment_by` is never used
  --> pilota-build/src/index.rs:14:8
   |
3  | pub trait Idx: Sized + Copy + 'static {
   |           --- method in this trait
...
14 |     fn increment_by(&mut self, amount: usize) {
   |        ^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 67 in pilota/src/prost/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric method

warning: usage of a legacy numeric method
  --> pilota/src/prost/mod.rs:67:24
   |
67 |     if length > usize::max_value() as u64 {
   |                        ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
   |
67 |     if length > usize::MAX as u64 {
   |                        ~~~

Check warning on line 9 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

importing legacy numeric constants

warning: importing legacy numeric constants
 --> pilota/src/prost/encoding.rs:9:55
  |
9 | use core::{cmp::min, convert::TryFrom, mem, str, u32, usize};
  |                                                       ^^^^^
  |
  = help: remove this import
  = note: then `usize::<CONST>` will resolve to the respective associated constant
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants

Check warning on line 9 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

importing legacy numeric constants

warning: importing legacy numeric constants
 --> pilota/src/prost/encoding.rs:9:50
  |
9 | use core::{cmp::min, convert::TryFrom, mem, str, u32, usize};
  |                                                  ^^^
  |
  = help: remove this import
  = note: then `u32::<CONST>` will resolve to the respective associated constant
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants

Check warning on line 4 in pilota/src/prost/message.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

importing legacy numeric constants

warning: importing legacy numeric constants
 --> pilota/src/prost/message.rs:4:24
  |
4 | use core::{fmt::Debug, usize};
  |                        ^^^^^
  |
  = help: remove this import
  = note: then `usize::<CONST>` will resolve to the respective associated constant
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
  = note: `#[warn(clippy::legacy_numeric_constants)]` on by default

Check warning on line 49 in pilota-build/src/resolve.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

elided lifetime has a name

warning: elided lifetime has a name
  --> pilota-build/src/resolve.rs:49:47
   |
48 | impl<'a> CollectDef<'a> {
   |      -- lifetime `'a` declared here
49 |     pub fn new(resolver: &'a mut Resolver) -> CollectDef {
   |                                               ^^^^^^^^^^ this elided lifetime gets resolved as `'a`
   |
   = note: `#[warn(elided_named_lifetimes)]` on by default

Check warning on line 246 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
   --> pilota/src/prost/encoding.rs:246:11
    |
246 |     #[cfg(feature = "no-recursion-limit")]
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `unstable`
    = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 236 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
   --> pilota/src/prost/encoding.rs:236:15
    |
236 |     #[cfg(not(feature = "no-recursion-limit"))]
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `unstable`
    = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 225 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
   --> pilota/src/prost/encoding.rs:225:11
    |
225 |     #[cfg(feature = "no-recursion-limit")]
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `unstable`
    = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 217 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
   --> pilota/src/prost/encoding.rs:217:15
    |
217 |     #[cfg(not(feature = "no-recursion-limit"))]
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `unstable`
    = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 196 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
   --> pilota/src/prost/encoding.rs:196:15
    |
196 |     #[cfg(not(feature = "no-recursion-limit"))]
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `unstable`
    = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 200 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
   --> pilota/src/prost/encoding.rs:200:11
    |
200 | #[cfg(not(feature = "no-recursion-limit"))]
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `unstable`
    = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 188 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
   --> pilota/src/prost/encoding.rs:188:12
    |
188 | #[cfg_attr(feature = "no-recursion-limit", derive(Default))]
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `unstable`
    = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 83 in pilota/src/prost/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `prost-derive`

warning: unexpected `cfg` condition value: `prost-derive`
  --> pilota/src/prost/mod.rs:83:7
   |
83 | #[cfg(feature = "prost-derive")]
   |       ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `unstable`
   = help: consider adding `prost-derive` as a feature in `Cargo.toml`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 79 in pilota/src/prost/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `prost-derive`

warning: unexpected `cfg` condition value: `prost-derive`
  --> pilota/src/prost/mod.rs:79:7
   |
79 | #[cfg(feature = "prost-derive")]
   |       ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `unstable`
   = help: consider adding `prost-derive` as a feature in `Cargo.toml`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 18 in pilota/src/prost/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
  --> pilota/src/prost/mod.rs:18:11
   |
18 | #[cfg(not(feature = "no-recursion-limit"))]
   |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `unstable`
   = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
   = note: `#[warn(unexpected_cfgs)]` on by default