Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add global descriptor release api #249

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

wujunyi792
Copy link
Contributor

@wujunyi792 wujunyi792 commented Dec 26, 2024

Description

Add ReleaseGlobalDescriptors func to release global Descriptor

Motivation and Context

We use thrift_reflection in server to parse thrift files. However, as time goes by, the server will crash due to OOM, the root cause is that the globalDescriptorMap only increases but never decreases. Therefore, an API is needed to clean up the unused GD.
image

Related Issue

@wujunyi792 wujunyi792 requested review from a team as code owners December 26, 2024 12:49
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


吴骏逸 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@HeyJavaBean HeyJavaBean merged commit f616652 into cloudwego:main Dec 26, 2024
3 of 4 checks passed
@wujunyi792 wujunyi792 deleted the feat/clean_global_descriptor branch December 26, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants