Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http): add cookie feature for client #512

Merged
merged 36 commits into from
Nov 4, 2024
Merged

feat(http): add cookie feature for client #512

merged 36 commits into from
Nov 4, 2024

Conversation

StellarisW
Copy link
Member

Motivation

add cookie feature for client

Solution

@StellarisW StellarisW requested review from a team as code owners October 24, 2024 08:22
@yukiiiteru
Copy link
Member

可以先去了解一下 Cookies 的作用和使用方式

yukiiiteru
yukiiiteru reviewed Oct 30, 2024
View reviewed changes
volo-http/src/client/cookie.rs Outdated
@@ -0,0 +1,88 @@
use std::sync::RwLock;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用异步锁

volo-http/src/client/mod.rs Outdated Show resolved Hide resolved
volo-http/src/client/mod.rs Outdated Show resolved Hide resolved
volo-http/src/utils/cookie/store.rs Outdated Show resolved Hide resolved
volo-http/src/utils/cookie/store.rs Outdated Show resolved Hide resolved
volo-http/src/utils/cookie/store.rs Outdated Show resolved Hide resolved
@yukiiiteru
Copy link
Member

提交前先用 scripts/selftest.sh 跑一下吧

yukiiiteru
yukiiiteru reviewed Oct 31, 2024
View reviewed changes
volo-http/src/request.rs Outdated Show resolved Hide resolved
volo-http/src/response.rs Outdated Show resolved Hide resolved
volo-http/src/client/mod.rs Outdated Show resolved Hide resolved
volo-http/src/client/cookie.rs Show resolved Hide resolved
yukiiiteru
yukiiiteru reviewed Nov 1, 2024
View reviewed changes
volo-http/src/response.rs Outdated Show resolved Hide resolved
volo-http/src/client/mod.rs Outdated Show resolved Hide resolved
volo-http/src/client/cookie.rs Outdated Show resolved Hide resolved
yukiiiteru
yukiiiteru previously approved these changes Nov 1, 2024
View reviewed changes
@yukiiiteru yukiiiteru merged commit e282982 into main Nov 4, 2024
14 of 16 checks passed
@yukiiiteru yukiiiteru deleted the feat(http)/cookie_jar branch November 4, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukiiiteru yukiiiteru yukiiiteru approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StellarisW @yukiiiteru