Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GCS emulators #177

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ Description: Interact with Google Cloud Storage <https://cloud.google.com/storag
API in R. Part of the 'cloudyr' <https://cloudyr.github.io/> project.
Authors@R: c(person("Mark", "Edmondson",email = "[email protected]",
role = c("aut", "cre"),
comment = c(ORCID = "0000-0002-8434-3881")))
comment = c(ORCID = "0000-0002-8434-3881")),
person("manuteleco",
email = "[email protected]",
role = "ctb",
comment = "<https://github.com/manuteleco>"))
URL: https://code.markedmondson.me/googleCloudStorageR/
BugReports: https://github.com/cloudyr/googleCloudStorageR/issues
Depends:
Expand Down Expand Up @@ -36,6 +40,6 @@ Remotes:
License: MIT + file LICENSE
LazyData: true
VignetteBuilder: knitr
RoxygenNote: 7.2.0
RoxygenNote: 7.2.1
Config/testthat/edition: 3
Config/testthat/parallel: false
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
* Fix bug where retry was not attempted on `gcs_upload()`
* Add some custom error classes `http_400`, `http_404` etc.
* Allow listing of more than 1000 buckets (#163 - thanks @hidekoji)
* Support GCS emulators and the `STORAGE_EMULATOR_HOST` environment variable
(#176 - thanks @manuteleco)

# googleCloudStorage 0.7.0

Expand Down
10 changes: 5 additions & 5 deletions R/acl.R
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ gcs_get_bucket_acl <- function(bucket = gcs_get_global_bucket(),
entity <- build_entity(entity, entity_type)

ge <-
gar_api_generator("https://storage.googleapis.com/storage/v1",
gar_api_generator(sprintf("%s/storage/v1", get_storage_host()),
"GET",
path_args = list(b = bucket,
acl = entity),
Expand Down Expand Up @@ -99,7 +99,7 @@ gcs_create_bucket_acl <- function(bucket = gcs_get_global_bucket(),
)

insert <-
gar_api_generator("https://storage.googleapis.com/storage/v1",
gar_api_generator(sprintf("%s/storage/v1", get_storage_host()),
"POST",
path_args = list(b = bucket,
acl = ""),
Expand Down Expand Up @@ -182,7 +182,7 @@ gcs_update_object_acl <- function(object_name,
)

insert <-
gar_api_generator("https://storage.googleapis.com/storage/v1",
gar_api_generator(sprintf("%s/storage/v1", get_storage_host()),
"POST",
path_args = list(b = bucket,
o = object_name,
Expand Down Expand Up @@ -261,8 +261,8 @@ gcs_get_object_acl <- function(object_name,
pa <- list(generation = generation)
}

url <- sprintf("https://storage.googleapis.com/storage/v1/b/%s/o/%s/acl/%s",
bucket, object_name, entity)
url <- sprintf("%s/storage/v1/b/%s/o/%s/acl/%s",
get_storage_host(), bucket, object_name, entity)
# storage.objectAccessControls.get
f <- gar_api_generator(url, "GET",
pars_args = pa,
Expand Down
8 changes: 4 additions & 4 deletions R/buckets.R
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ gcs_list_buckets <- function(projectId,
}

lb <-
googleAuthR::gar_api_generator("https://storage.googleapis.com/storage/v1/b",
googleAuthR::gar_api_generator(sprintf("%s/storage/v1/b", get_storage_host()),
"GET",
pars_args = list(project=projectId,
prefix=prefix,
Expand Down Expand Up @@ -202,7 +202,7 @@ gcs_get_bucket <- function(bucket = gcs_get_global_bucket(),
pars_args <- rmNullObs(pars_args)

bb <-
googleAuthR::gar_api_generator("https://storage.googleapis.com/storage/v1/",
googleAuthR::gar_api_generator(sprintf("%s/storage/v1/", get_storage_host()),
"GET",
path_args = list(b = bucket),
pars_args = pars_args)
Expand Down Expand Up @@ -275,7 +275,7 @@ gcs_create_bucket <-
projection = projection)
pars_args <- rmNullObs(pars_args)

bb <- gar_api_generator("https://storage.googleapis.com/storage/v1/b",
bb <- gar_api_generator(sprintf("%s/storage/v1/b", get_storage_host()),
"POST",
pars_args = pars_args)

Expand Down Expand Up @@ -333,7 +333,7 @@ gcs_delete_bucket <- function(bucket,
ifMetagenerationNotMatch=ifMetagenerationNotMatch)
pars_args <- rmNullObs(pars_args)

bb <- gar_api_generator("https://storage.googleapis.com/storage/v1/",
bb <- gar_api_generator(sprintf("%s/storage/v1/", get_storage_host()),
"DELETE",
path_args = list(b = bucket),
pars_args = pars_args)
Expand Down
2 changes: 1 addition & 1 deletion R/compose.R
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ gcs_compose_objects <- function(objects,
)
)

ob <- gar_api_generator("https://storage.googleapis.com/storage/v1",
ob <- gar_api_generator(sprintf("%s/storage/v1", get_storage_host()),
"POST",
path_args = list(b = bucket,
o = destination,
Expand Down
4 changes: 2 additions & 2 deletions R/download.R
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ gcs_download_url <- function(object_name,
}

domain <- "https://storage.cloud.google.com"
if(public){
domain <- "https://storage.googleapis.com"
if(public || is.storage_emulated()){
domain <- get_storage_host()
}

file.path(domain, bucket, object_name, fsep = "/")
Expand Down
19 changes: 19 additions & 0 deletions R/host.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
## Google Cloud Storage API host, used by default
.default_storage_host <- "https://storage.googleapis.com"

#' Get the Google Cloud Storage API host to use for requests
#'
#' Uses the \code{STORAGE_EMULATOR_HOST} environment variable if set, otherwise
#' uses the default host (the real Google Cloud Storage API).
#'
#' @return The host to use for requests (includes scheme, host and port)
get_storage_host <- function() {
Sys.getenv("STORAGE_EMULATOR_HOST", .default_storage_host)
}

#' Check if the Google Cloud Storage API is emulated
#'
#' @return TRUE if the Google Cloud Storage API is emulated, FALSE otherwise
is.storage_emulated <- function() {
!is.null(Sys.getenv("STORAGE_EMULATOR_HOST"))
}
10 changes: 5 additions & 5 deletions R/objects.R
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ gcs_list_objects <- function(bucket = gcs_get_global_bucket(),
versions = versions)
pars <- rmNullObs(pars)

lo <- gar_api_generator("https://storage.googleapis.com/storage/v1/",
lo <- gar_api_generator(sprintf("%s/storage/v1/", get_storage_host()),
path_args = list(b = bucket,
o = ""),
pars_args = pars,
Expand Down Expand Up @@ -263,7 +263,7 @@ gcs_get_object <- function(object_name,
fields = fields)
pars_args <- rmNullObs(pars_args)

ob <- gar_api_generator("https://storage.googleapis.com/storage/v1/",
ob <- gar_api_generator(sprintf("%s/storage/v1/", get_storage_host()),
path_args = list(b = bucket,
o = object_name),
pars_args = pars_args,
Expand Down Expand Up @@ -387,7 +387,7 @@ gcs_delete_object <- function(object_name,
pars <- list(generation = generation)
pars <- rmNullObs(pars)

ob <- gar_api_generator("https://storage.googleapis.com/storage/v1/",
ob <- gar_api_generator(sprintf("%s/storage/v1/", get_storage_host()),
"DELETE",
path_args = list(b = bucket,
o = object_name),
Expand Down Expand Up @@ -446,8 +446,8 @@ gcs_copy_object <- function(source_object,
source_object <- URLencode(source_object, reserved = TRUE)
destination_object <- URLencode(destination_object, reserved = TRUE)

the_url <- sprintf("https://storage.googleapis.com/storage/v1/b/%s/o/%s/copyTo/b/%s/o/%s",
source_bucket, source_object, destination_bucket, destination_object)
the_url <- sprintf("%s/storage/v1/b/%s/o/%s/copyTo/b/%s/o/%s",
get_storage_host(), source_bucket, source_object, destination_bucket, destination_object)
pars <- NULL
if(!is.null(rewriteToken)){
pars <- list(rewriteToken = rewriteToken)
Expand Down
4 changes: 4 additions & 0 deletions R/options.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
toset <- !(names(op.googleCloudStorageR) %in% names(op))

if(any(toset)) options(op.googleCloudStorageR[toset])

if(is.storage_emulated()){
options(googleAuthR.skip_token_checks = TRUE)
}

invisible()

Expand Down
16 changes: 8 additions & 8 deletions R/pubsub.R
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ gcs_create_pubsub <- function(topic,

the_body <- rmNullObs(the_body)

the_url <- sprintf("https://storage.googleapis.com/storage/v1/b/%s/notificationConfigs",
bucket)
the_url <- sprintf("%s/storage/v1/b/%s/notificationConfigs",
get_storage_host(), bucket)

api <- gar_api_generator(the_url, "POST", data_parse_function = function(x) x)

Expand All @@ -85,8 +85,8 @@ gcs_get_service_email <- function(project){

assert_that(is.string(project))

the_url <- sprintf("https://storage.googleapis.com/storage/v1/projects/%s/serviceAccount",
project)
the_url <- sprintf("%s/storage/v1/projects/%s/serviceAccount",
get_storage_host(), project)

api <- gar_api_generator(the_url, "GET",
data_parse_function = function(x){x$email_address})
Expand Down Expand Up @@ -120,8 +120,8 @@ gcs_list_pubsub <- function(bucket = gcs_get_global_bucket()){
bucket <- as.bucket_name(bucket)


the_url <- sprintf("https://storage.googleapis.com/storage/v1/b/%s/notificationConfigs",
bucket)
the_url <- sprintf("%s/storage/v1/b/%s/notificationConfigs",
get_storage_host(), bucket)

api <- gar_api_generator(the_url, "GET",
data_parse_function = function(x) x$items)
Expand Down Expand Up @@ -159,8 +159,8 @@ gcs_delete_pubsub <- function(config_name,

assert_that(is.string(config_name))

the_url <- sprintf("https://storage.googleapis.com/storage/v1/b/%s/notificationConfigs/%s",
bucket, config_name)
the_url <- sprintf("%s/storage/v1/b/%s/notificationConfigs/%s",
get_storage_host(), bucket, config_name)


# to avoid some warning messages due to empty body
Expand Down
8 changes: 4 additions & 4 deletions R/upload.R
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ do_simple_upload <- function(name,
}

up <-
gar_api_generator("https://storage.googleapis.com/upload/storage/v1",
gar_api_generator(sprintf("%s/upload/storage/v1", get_storage_host()),
"POST",
path_args = list(b = bucket,
o = ""),
Expand Down Expand Up @@ -425,8 +425,8 @@ do_multipart_upload <- function(name,
pars_args[["predefinedAcl"]] <- predefinedAcl
}

the_url <- sprintf("https://storage.googleapis.com/upload/storage/v1/b/%s/o",
bucket)
the_url <- sprintf("%s/upload/storage/v1/b/%s/o",
get_storage_host(), bucket)
up <-
gar_api_generator(the_url,
"POST",
Expand Down Expand Up @@ -458,7 +458,7 @@ do_resumable_upload <- function(name,
}

up <-
googleAuthR::gar_api_generator("https://storage.googleapis.com/upload/storage/v1",
googleAuthR::gar_api_generator(sprintf("%s/upload/storage/v1", get_storage_host()),
"POST",
path_args = list(b = bucket,
o = ""),
Expand Down
6 changes: 4 additions & 2 deletions R/versioning.R
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ gcs_version_bucket <- function(bucket,

# will only be different for list
url <- sprintf(
"https://storage.googleapis.com/storage/v1/b/%s",
"%s/storage/v1/b/%s",
get_storage_host(),
bucket
)
pars_args <- list(fields = "versioning")
Expand Down Expand Up @@ -102,7 +103,8 @@ gcs_version_bucket <- function(bucket,
# Archived versions of objects have a `timeDeleted` property.

url <- sprintf(
"https://storage.googleapis.com/storage/v1/b/%s/o",
"%s/storage/v1/b/%s/o",
get_storage_host(),
bucket
)
pars_args <- list(versions = "true")
Expand Down
2 changes: 1 addition & 1 deletion man/gcs_upload.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions man/get_storage_host.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions man/is.storage_emulated.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 37 additions & 0 deletions vignettes/googleCloudStorageR.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,43 @@ gcs_get_global_bucket()
[1] "my-default-bucket-2"
```

## Using a GCS emulator

You can also use a GCS emulator instead of the real Google Cloud Storage. By
providing a `STORAGE_EMULATOR_HOST` environment variable, the library will
direct all API request to the emulator server. The variable's value should
include scheme, host and port (e.g.: `http://localhost:8080`).

When using an emulator, you don't have to provide authentication credentials.

This is generally useful in the context of automated tests. And depending on the
emulator implementation, it can even give local filesystem support to
applications that were previously hardwired to use GCS.

```r
## start a GCS emulator outside R listening at 127.0.0.1:1234, for example

## set emulator host via environment
Sys.setenv("STORAGE_EMULATOR_HOST" = "http://127.0.0.1:1234")

library(googleCloudStorageR)

proj <- "my-dummy-project-id"

# perform GCS operations normally, like:
gcs_create_bucket("my-bucket", proj)
==Google Cloud Storage Bucket==
Bucket: my-bucket
Location: US-CENTRAL1
Class: STANDARD
Created: 2023-07-22 07:31:28
Updated: 2023-07-22 07:31:28

gcs_list_buckets(proj)
name storageClass location updated
1 my-bucket STANDARD US-CENTRAL1 2023-07-22 07:31:28
```

## Downloading objects from Google Cloud storage

Once you have a Google project and created a bucket with an object in it, you can download it as below:
Expand Down