Bff/token optimisation #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bff training tweaks
fixed task name
|
This is very useful! One small findings: |
|
Ah yes, thanks for catching that - removed the file. I should have put some context in the original PR. This is to fix the issue I flagged here #266 |
|
@bugface – let me know if you're happy to merge :) |
I think it looks great. |
|
I think we're good to merge then, @bugface :) |
|
news about this? @bugface |
matteocacciola
suggested changes
Jul 10, 2024
|
Ah yeah, I guess bad style. At the time I wanted to be explicit because this bug was so opaque. Are you happy to merge if I fix that? |
|
I could be interested in patching it into my fork, if you fix and explain the changes. Thank you.
|
| if len(set(list_of_tokens) - set(self.tokenizer.all_special_tokens)) > 0: | ||
| newly_added_num = self.tokenizer.add_special_tokens({"additional_special_tokens": sorted(set(list_of_tokens))}, replace_additional_special_tokens=replace_additional_special_tokens) | ||
| else: | ||
| newly_added_num = 0 |
There was a problem hiding this comment.
I guess this is the real solution to the detected bug, isn't it?
matteocacciola
added a commit
to matteocacciola/donut
that referenced
this pull request
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix: #266