Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tally - do not fetch logs if tally hash was published #710

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

yuetloo
Copy link
Collaborator

@yuetloo yuetloo commented Aug 21, 2023

Currently, the tally task only skips fetching MACI event logs if the MACI log file path is given. During re-run, if the task already successfully completed tallying, and only need to re-run the part that upload tally result to the contract, it should not fetch MACI logs.

@yuetloo yuetloo self-assigned this Aug 21, 2023
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yuetloo yuetloo merged commit cfdd301 into develop Aug 21, 2023
2 checks passed
@yuetloo yuetloo deleted the fix/tally-rerun branch August 21, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants