Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a pull request template #41

Closed
2 tasks
MarchandMD opened this issue Dec 17, 2023 · 4 comments · Fixed by #43
Closed
2 tasks

Create a pull request template #41

MarchandMD opened this issue Dec 17, 2023 · 4 comments · Fixed by #43
Assignees

Comments

@MarchandMD
Copy link
Contributor

Description:

as a developer
when I make a pr
I want the body of the PR to have a PR template for me to complete

Tasks:

  • Add a PR template

Resources:

Additional remarks:

Probably a good initial setup step to allow people to create issues

@Philip-Clark
Copy link
Contributor

@MarchandMD is this a possible duplicate of #33 ?

Or are you talking about PR templates and not Issue templates?
I think both are probably worth implementing but wanted to clarify as the link you shared has both Issue and PR templates, and you mentioned "Probably a good initial setup step to allow people to create issues".

@MarchandMD
Copy link
Contributor Author

Forgive the mixed message on my issue; Yeah, I'm talking about PR templates.

And I'm happy to throw a review on that issue template issue you've got

@Philip-Clark
Copy link
Contributor

@MarchandMD Sounds great. I'll look into adding PR templates unless this is something you would like to do.

A review of the PR I made would be great. I'd love input on what types of templates we should implement as well

@Philip-Clark
Copy link
Contributor

PR #43 will close this upon merge.
Awaiting review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants