Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/: Create PULL_REQUEST_TEMPLATE.md #43

Merged
merged 4 commits into from
Dec 20, 2023
Merged

.github/: Create PULL_REQUEST_TEMPLATE.md #43

merged 4 commits into from
Dec 20, 2023

Conversation

Philip-Clark
Copy link
Contributor

Because

PR templates enable uniform and efficient PR's.

This PR

  • Create PULL_REQUEST_TEMPLATE.md
  • Adapt The Odin Project PR template to suit Odin Pantry's needs

Issue

Closes #41

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Menu.js: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section

@Philip-Clark Philip-Clark mentioned this pull request Dec 20, 2023
Closed
2 tasks
MarchandMD
MarchandMD reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@MarchandMD MarchandMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of simple thoughts; let me know what you think

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@Philip-Clark
Update PULL_REQUEST_TEMPLATE.md
4fdafba 
Update wording to make the PR template more beginner-friendly
MarchandMD
MarchandMD approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@MarchandMD MarchandMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great! If other people feel differently/strongly about any of it, we can always re-visit

@Philip-Clark Philip-Clark merged commit a125cac into club-40:main Dec 20, 2023
1 check passed
@Philip-Clark Philip-Clark deleted the Philip-Clark-pr-template branch December 20, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarchandMD MarchandMD MarchandMD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a pull request template
2 participants
@Philip-Clark @MarchandMD