Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update issue templates #42

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Update issue templates #42

merged 3 commits into from
Dec 18, 2023

Conversation

Philip-Clark
Copy link
Contributor

Add Issue templates for bugs, Suggestions, and "Other" issues. More templates should be added

@Philip-Clark
Update issue templates
effb913 
Add Issue templates for bugs, Suggestions, and "Other" issues. More templates should be added
@Philip-Clark Philip-Clark self-assigned this Dec 18, 2023
@Philip-Clark Philip-Clark requested a review from a team December 18, 2023 23:02
@Philip-Clark Philip-Clark mentioned this pull request Dec 18, 2023
Closed
1 task
@Philip-Clark Philip-Clark added enhancement New feature or request decision needed This discussion requires a decision to be made labels Dec 18, 2023
@Philip-Clark
Copy link
Contributor Author

@MarchandMD shared this repo with a lot of good templates. Feel free to suggest some to be added and I'll do my best to add them.

MarchandMD
MarchandMD approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@MarchandMD MarchandMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Perhaps the "Desktop" and "Smartphone" sections on the bug reports are overkill, but I'm not gonna hold this PR up; Better to have something to iterate on first

@Philip-Clark
Copy link
Contributor Author

@MarchandMD
I can remove the smartphone and desktop section in favor of a simple browser section. Good call

@Philip-Clark
Update bug_report.md
dd329b0 
Remove smartphone and Desktop sections under environments.
Update some styling to match other templates
@Philip-Clark
Update bug_report.md
0cd709e 
Remove OS from enviroment
MarchandMD
MarchandMD approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@MarchandMD MarchandMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these updates; make it easier to start the conversation surrounding an issue. If additional clarity is needed, it should be on us to either seek clarity or dismiss the issue

@Philip-Clark Philip-Clark removed the request for review from a team December 18, 2023 23:44
@Philip-Clark Philip-Clark merged commit b27ea28 into main Dec 18, 2023
4 checks passed
@Philip-Clark Philip-Clark deleted the Philip-Clark-issue-templates branch December 18, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarchandMD MarchandMD MarchandMD approved these changes

Assignees

@Philip-Clark Philip-Clark

Labels
decision needed This discussion requires a decision to be made enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Philip-Clark @MarchandMD