Update close handler to avoid unhandled promise rejections

clue · Apr 9, 2024 · 703bcbb · 703bcbb
1 parent b9e1912
commit 703bcbb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/ProxyConnector.php b/src/ProxyConnector.php
@@ -159,6 +159,8 @@ public function connect($uri)
             // either close active connection or cancel pending connection attempt
             $connecting->then(function (ConnectionInterface $stream) {
                 $stream->close();
+            }, function () {
+                // ignore to avoid reporting unhandled rejection
             });
             $connecting->cancel();
         });

diff --git a/tests/ProxyConnectorTest.php b/tests/ProxyConnectorTest.php
@@ -542,6 +542,9 @@ public function testRejectedConnectionShouldNotCreateGarbageCycles()
         $proxy = new ProxyConnector('proxy.example.com', $this->connector);
 
         $promise = $proxy->connect('google.com:80');
+
+        $promise->then(null, $this->expectCallableOnce()); // avoid reporting unhandled rejection
+
         unset($promise);
 
         $this->assertEquals(0, gc_collect_cycles());