Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible update fixes #128

Open
wants to merge 2 commits into
base: 6
Choose a base branch
from

Conversation

GMW99
Copy link

@GMW99 GMW99 commented Jun 1, 2022

Epel has now released version 5.4 of Ansible within stable with this there are a few things that broke these are the fixes.

  • Selinux commands
    • Ansible no longer defaults to platform-python which is python3.6 which allows the python36-libselinux package to be used, instead it uses python3.8 and therefore the libselinux package cannot be used due to being a different version. The fix was to set the ansible python interpreter to platform-python as this defaults to python3.6 and is the recommended solution: https://bugzilla.redhat.com/show_bug.cgi?id=2091684
  • grafana_datasource module

= added 2 commits June 1, 2022 10:03
As of the update, ansible does not default to the platform-python. This causes errors with the SELinux commands as the module they require is in python3.6, not 3.8, which ansible defaults to. Using platform Linux as it is is python3.6 solves this issue.
This task fails on the new version of ansible on the epel repo as the use of url now refers to the grafana_url, not the data source as it did previously. Making the url explicit with ds_url solves this problem.
@milliams
Copy link
Member

milliams commented Jun 1, 2022

I've been annoyed that we're stuck on Ansible 2.9 for so long so the fact that 5 is now available in EPEL is very welcome news. Given how much has changed in Ansible in the meantime, I'm surprised that this is all the changes that are needed. To give some more confidence, would you be able to also edit the CI config file (.github/workflows/main.yml) in your branch to change the version of Ansible specified from:

'ansible<2.10,>=2.9' 'ansible-lint<6.0.0'

to perhaps

'ansible>=5,<6' 'ansible-lint'

I expect there are things that will not be compatible.

Furthermore, the mgmt node bootstrap from Terraform (https://github.com/clusterinthecloud/terraform/blob/master/common-files/bootstrap.sh.tpl) runs Ansible before having installed EPEL so it will currently still be getting Ansible 2.9 (whereas the compute nodes to install EPEL before Ansible so will get the new version - https://github.com/clusterinthecloud/ansible/blob/6/roles/packer/templates/prepare_ansible.sh.j2). We might also need to install ansible-collection-community-general to get all the core community roles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants