Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clusterpedia openapi and bump k8s dependency to v1.28.2 #579

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

wawa0210
Copy link
Member

@wawa0210 wawa0210 commented Oct 12, 2023

What type of PR is this?

/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

The reason for adding ignored static check SA1019 is that a method is marked as deprecated, but the changes are relatively large and have not been changed yet. Later we can try to modify PR alone .The detailed error is as follows

  Running [/home/runner/golangci-lint-1.53.3-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: SA1019: wait.NewExponentialBackoffManager is deprecated: Will be removed when the legacy Poll methods are removed. Callers should construct a Backoff struct, use DelayWithReset() to get a DelayFunc that periodically resets itself, and then invoke Timer() when calling wait.BackoffUntil. (staticcheck)
  Error: SA1019: wait.NewExponentialBackoffManager is deprecated: Will be removed when the legacy Poll methods are removed. Callers should construct a Backoff struct, use DelayWithReset() to get a DelayFunc that periodically resets itself, and then invoke Timer() when calling wait.BackoffUntil. (staticcheck)
  
  level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
  level=warning msg="[runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
  level=warning msg="[runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
  
  Error: issues found

detail link --> href

relation code

Does this PR introduce a user-facing change?:


@clusterpedia-bot
Copy link

Hi @wawa0210,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot
Copy link

@wawa0210

Failed add label kind/flake
Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@wawa0210 wawa0210 force-pushed the main branch 12 times, most recently from 9091236 to 88c48f4 Compare October 18, 2023 08:48
@wawa0210 wawa0210 force-pushed the main branch 9 times, most recently from 3676498 to 008d42b Compare October 25, 2023 09:38
@Iceber
Copy link
Member

Iceber commented Oct 25, 2023

bump k8s dependency to latest version

It is recommended that the commit message and pr title be changed to be specific version

bump k8s dependency to v1.28.2

@wawa0210 wawa0210 changed the title bump k8s dependency to latest version bump k8s dependency to v1.28.2 Oct 26, 2023
@wawa0210 wawa0210 force-pushed the main branch 3 times, most recently from 0f7b834 to 4c232df Compare October 26, 2023 02:03
@wawa0210 wawa0210 changed the title bump k8s dependency to v1.28.2 add clusterpedia openapi and bump k8s dependency to v1.28.2 Oct 26, 2023
Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution

@Iceber Iceber added kind/dependencies Pull requests that update a dependency file kind/feature New feature labels Oct 26, 2023
@Iceber Iceber merged commit b479aea into clusterpedia-io:main Oct 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependencies Pull requests that update a dependency file kind/feature New feature size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants