Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added more certificate and test use sqlite db related ignore for .gitignore #608

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

nekomeowww
Copy link
Contributor

@nekomeowww nekomeowww commented Nov 28, 2023

What type of PR is this

/kind cleanup

What this PR does / why we need it

Subset changes for #602. It wasn't enough for just ignoring the existing extensions, and #607 introduces test.db files in unit tests, this Pull Request suggest to cover more ignorance of certificate related extensions and test.db.

Which issue(s) this PR fixes

None.

Special notes for your reviewer

Does this PR introduce a user-facing change

NONE

@clusterpedia-bot
Copy link

Hi @nekomeowww,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot
Copy link

@nekomeowww

Failed add label kind/design
Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

.gitignore Outdated Show resolved Hide resolved
@nekomeowww
Copy link
Contributor Author

/kind cleanup

@clusterpedia-bot clusterpedia-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 28, 2023
Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Iceber Iceber merged commit eb9ba3f into clusterpedia-io:main Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants