Fail if a sketch file is a broken symlink

cmaglie · Jan 11, 2024 · 719185d · 719185d
1 parent f793bb1
commit 719185d
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/internal/arduino/sketch/sketch.go b/internal/arduino/sketch/sketch.go
@@ -176,7 +176,10 @@ func (s *Sketch) supportedFiles() (paths.PathList, error) {
 
 	files, err := s.FullPath.ReadDirRecursiveFiltered(
 		paths.AndFilter(
-			filterOutBrokenLinks,
+			paths.OrFilter(
+				filterValidExtensions,
+				filterOutBrokenLinks,
+			),
 			filterOutBuildPaths,
 		),
 		paths.AndFilter(

diff --git a/internal/integrationtest/compile_4/broken_symlink_test.go b/internal/integrationtest/compile_4/broken_symlink_test.go
@@ -37,4 +37,11 @@ func TestCompileWithBrokenSymLinks(t *testing.T) {
 		_, _, err = cli.Run("compile", "-b", "arduino:avr:uno", sketch.String())
 		require.NoError(t, err)
 	})
+
+	t.Run("SketchFileBroken", func(t *testing.T) {
+		sketch, err := paths.New("testdata", "ValidSketchWithBrokenSketchFileSymlink").Abs()
+		require.NoError(t, err)
+		_, _, err = cli.Run("compile", "-b", "arduino:avr:uno", sketch.String())
+		require.Error(t, err)
+	})
 }
diff --git a/...estdata/ValidSketchWithBrokenSketchFileSymlink/ValidSketchWithBrokenSketchFileSymlink.ino b/...estdata/ValidSketchWithBrokenSketchFileSymlink/ValidSketchWithBrokenSketchFileSymlink.ino
@@ -0,0 +1,2 @@
+void setup() {}
+void loop() {}
diff --git a/...rnal/integrationtest/compile_4/testdata/ValidSketchWithBrokenSketchFileSymlink/other_file b/...rnal/integrationtest/compile_4/testdata/ValidSketchWithBrokenSketchFileSymlink/other_file
@@ -0,0 +1 @@
+broken