Refactor additional entries #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibrary func The ResolveLibrary func is only called by the ContainerFindIncludes
cmaglie
pushed a commit
that referenced
this pull request
Sep 5, 2023
#32 * refactor AddAdditionalEntriesToContext in a function * use the new function in all the tests * Move the assignaton of LibrariesResolutionResults inside the ResolveLibrary func The ResolveLibrary func is only called by the ContainerFindIncludes * rename bPath to buildPath * cleanup usless tests * remove shadowed variable
cmaglie
added a commit
to arduino/arduino-cli
that referenced
this pull request
Sep 6, 2023
* Simplified compileFiles * Starting new Builder (part 1/n) * builder: renamed variable and moved dir creation up * builder: made a sketch-prepress function part of Builder * Removed ctx dependency in PreprocessSketchWithArduinoPreprocessor * uniform parameters between preprocesors * Moved PreprocessSketchWithArduinoPreprocessor into proper place * Inlined function * Converted sketchCopyAdditionalFiles into a Builder method * Made SetupBuildProperties a method of the new Builder * Refactor AddAdditionalEntriesToContext cmaglie#32 * refactor AddAdditionalEntriesToContext in a function * use the new function in all the tests * Move the assignaton of LibrariesResolutionResults inside the ResolveLibrary func The ResolveLibrary func is only called by the ContainerFindIncludes * rename bPath to buildPath * cleanup usless tests * remove shadowed variable * Refactor legacy LibrariesLoader command * move LibrariesLoader under arduino/builder * remove usless nil check * remove AddAdditionalEntries func, in favour of initializing them in the compile command * move a check directly in the compile command * create the SketchLibrariesDetector struct * move all the logic of ContainerSetupHardwareToolsLibsSketchAndProps in the compile command * remove container_setup and adjust relative tests * remove LibraryResolver property from context * remove UseCachedLibrariesResolution for context * remove ImportedLibraries from context * remove LibrariesResolutionResults from context * remove LibrariesManager from context * fix regression exceeding 100% status bar * refactor find_includes * refactoring the cmd.Exec in favour of executils * use detector FindIncludes in tests * add comments and make some plubic methods private --------- Co-authored-by: Alessio Perugini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information