Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor legacy libraries loader #33

Merged

Conversation

alessio-perugini
Copy link

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #33 (57dc8d7) into builder_refactor (90994dd) will decrease coverage by 0.01%.
The diff coverage is 74.62%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@                 Coverage Diff                  @@
##           builder_refactor      #33      +/-   ##
====================================================
- Coverage             63.35%   63.34%   -0.01%     
====================================================
  Files                   220      217       -3     
  Lines                 19537    19527      -10     
====================================================
- Hits                  12378    12370       -8     
  Misses                 6079     6079              
+ Partials               1080     1078       -2     
Flag Coverage Δ
unit 63.34% <74.62%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
legacy/builder/create_cmake_rule.go 8.30% <0.00%> (ø)
legacy/builder/types/context.go 97.61% <ø> (ø)
legacy/builder/types/types.go 85.71% <ø> (ø)
commands/compile/compile.go 68.78% <65.30%> (-0.70%) ⬇️
arduino/builder/libraries.go 76.29% <76.29%> (ø)
legacy/builder/container_find_includes.go 70.00% <83.33%> (-1.82%) ⬇️
legacy/builder/builder.go 82.52% <100.00%> (-1.96%) ⬇️
legacy/builder/phases/libraries_builder.go 76.15% <100.00%> (ø)
legacy/builder/print_used_libraries_if_verbose.go 100.00% <100.00%> (ø)
...egacy/builder/unused_compiled_libraries_remover.go 76.00% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmaglie cmaglie merged commit 3bf163d into cmaglie:builder_refactor Sep 5, 2023
87 of 88 checks passed
@cmaglie cmaglie deleted the refactor_legacy_libraries_loader branch September 5, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants