Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large Screens Container Fixes #51

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Large Screens Container Fixes #51

merged 1 commit into from
Oct 31, 2024

Conversation

xcrap
Copy link
Contributor

@xcrap xcrap commented Oct 28, 2024

So i've added a max-width to the main container, I use very large resolutions and the width had no limit which is too much for the readability, it's the same issue while tailwind has max-w-prose in the prose because there's a limit text is readable at an horizontal level and also fluid layouts can suffer from extreme widths regarding with text distribution.

Before:
before

After:
after

I've used the default Tailwind cases to max-w-screen-2xl of 1536px, maybe could be even set to max-w-screen because I believe anything larger than 1200px starts to open too much.

Copy link

netlify bot commented Oct 28, 2024

‼️ Deploy request for giffium rejected.

Name Link
🔨 Latest commit 5bf53cf

Copy link
Owner

@cmgriffing cmgriffing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. We will probably have to reevaluate the exact values again when we move the settings to a sidebar so not a big deal if the max width you set is still too wide. It is at least better than it was.

@cmgriffing cmgriffing merged commit 4e01231 into cmgriffing:main Oct 31, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants