Fix clippy

cmpute · Dec 31, 2023 · f1eb119 · f1eb119
1 parent f598436
commit f1eb119
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 3 deletions.
diff --git a/float/src/lib.rs b/float/src/lib.rs
@@ -86,6 +86,7 @@ mod third_party;
 mod utils;
 
 // All the public items from third_party will be exposed
+#[allow(unused_imports)]
 pub use third_party::*;
 
 pub use fbig::FBig;

diff --git a/float/src/third_party/num_traits.rs b/float/src/third_party/num_traits.rs
@@ -132,6 +132,8 @@ impl<R: Round, const B: Word> num_traits::Num for FBig<R, B> {
     type FromStrRadixErr = ParseError;
     #[inline]
     fn from_str_radix(str: &str, radix: u32) -> Result<Self, Self::FromStrRadixErr> {
+        // the conversion might a fail with 16-bit words.
+        #[allow(clippy::unnecessary_fallible_conversions)]
         let r: Word = radix.try_into().map_err(|_| ParseError::UnsupportedRadix)?;
         if r == B {
             Self::from_str_native(str)

diff --git a/integer/src/lib.rs b/integer/src/lib.rs
@@ -134,6 +134,7 @@ mod third_party;
 mod ubig;
 
 // All the public items from third_party will be exposed
+#[allow(unused_imports)]
 pub use third_party::*;
 
 // Re-export types for fast division

diff --git a/integer/src/repr.rs b/integer/src/repr.rs
@@ -167,7 +167,8 @@ impl Repr {
                 1 | 2 => {
                     TypedReprRef::RefSmall(double_word(self.data.inline[0], self.data.inline[1]))
                 }
-                _ => TypedReprRef::RefLarge(slice::from_raw_parts( // need Rust 1.64 for const
+                _ => TypedReprRef::RefLarge(slice::from_raw_parts(
+                    // need Rust 1.64 for const
                     self.data.heap.0,
                     self.data.heap.1,
                 )),

diff --git a/integer/tests/modular.rs b/integer/tests/modular.rs
@@ -131,9 +131,10 @@ fn test_add_sub() {
         ),
     ];
 
+    #[allow(clippy::map_identity)]
     let all_test_cases = test_cases
         .iter()
-        .map(|(a, b, c)| (a, b, c))
+        .map(|(a, b, c)| (a, b, c)) // Need identity map to convert tuple ref to ref tuple
         .chain(test_cases.iter().map(|(a, b, c)| (b, a, c)));
 
     for (a, b, c) in all_test_cases {
@@ -201,9 +202,10 @@ fn test_mul() {
         ),
     ];
 
+    #[allow(clippy::map_identity)]
     let all_test_cases = test_cases
         .iter()
-        .map(|(a, b, c)| (a, b, c))
+        .map(|(a, b, c)| (a, b, c)) // Need identity map to convert tuple ref to ref tuple
         .chain(test_cases.iter().map(|(a, b, c)| (b, a, c)));
 
     for (a, b, c) in all_test_cases {

diff --git a/rational/src/lib.rs b/rational/src/lib.rs
@@ -73,6 +73,7 @@ mod simplify;
 mod third_party;
 
 // All the public items from third_party will be exposed
+#[allow(unused_imports)]
 pub use third_party::*;
 
 pub use rbig::{RBig, Relaxed};