-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bin-wise-stats.md #929
base: main
Are you sure you want to change the base?
Conversation
Dear combine experts, as far as I understand the following code block defines the algorithm of the From my understanding this does not align with the description in the documentation: https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest/part2/bin-wise-stats/#description-of-the-algorithm Can you clarify how the algorithm is implemented for the case where Best, Peter |
Hi Peter, I think the description aligns with the code. Below the Poisson threshold for the sum of processes we do Poisson when the individual process is below the same threshold (this part), otherwise Gaussian (this part). There is also one subtle case not described in the docs, when the per-process error is larger than the bin contents, we cannot form a Poisson uncertainty even if we wanted to, so we put a Gaussian instead (this part). |
Hi @ajgilbert, thank you very much for your fast reply. Oooh I think I got it... in case Is my understanding now correct? Best, Peter |
Yes, exactly that :-) The reason is that Gaussian pdfs are faster to evaluate than Poissons, so we prefer to use them when we can. |
Thank you so much for your explanation @ajgilbert ! I still think that one sentence needs a revision in the documentation (last point 7): - The Poisson-constrained parameters are expressed as a yield multiplier with nominal value one: $n_{tot}\cdot v$.
+ The Poisson-constrained parameters are expressed as a yield multiplier with nominal value one: $n_{i} \cdot v$. Since the Poisson parameters should act on each process individually, don't they? If you don't mind I would go ahead and update this PR with:
Is this alright with you? |
Dear combine experts,
this PR updates the description of the$n_{tot}^{eff}$ is below the threshold (Poisson constrained case). Can you confirm that the description algorithm is correct now?
autoMCstats
algorithm. Two descriptions are (likely) more correctly described now regarding the case where theBest, Peter