Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include first version of the 2TagCount code #127

Open
wants to merge 7 commits into
base: 9_4_X
Choose a base branch
from

Conversation

capalmer85
Copy link
Contributor

@Wilsker Is this the right branch to merge into? (Pointing you to the lines in question in a moment.)

// N.B. for GetBinContent(X) 'X' must be weight index + 1 due to way histogram is filled (0th bin always underflow).
systWeight["qcdScaleLo"]=ev.ttbar_w[9]*(xsecWgt->GetBinContent(10)/xsecWgt->GetBinContent(1));
systWeight["qcdScaleHi"]=ev.ttbar_w[5]*(xsecWgt->GetBinContent(6)/xsecWgt->GetBinContent(1));
systWeight["hdampLo"]=ev.ttbar_w[ev.ttbar_nw-29]*(xsecWgt->GetBinContent(ev.ttbar_nw-29+1)/xsecWgt->GetBinContent(1));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wilsker These weights don't seem correct. From data/mc it is clear mc normalization is much too large. Is there another factor?

@mverzett
Copy link

mverzett commented Apr 9, 2019

@capalmer85 it's fine to merge it here, but you should also forward port to all the following branches (10.2 etc..).

Given the analysis code is quite independent from the BTA release cycle you could/should open a new repository under cms-btv-pog to keep your code there.

@capalmer85
Copy link
Contributor Author

@mverzett Thanks for having a look. I've integrated this code with the same code for the kin fit. In fact the only part that is really independent is the part that measures efficiency from the histograms (although kin fit has a separate script like that too).

Maybe everything in test/ttbar should go into a new repo? @Wilsker what do you think?

@Wilsker
Copy link
Contributor

Wilsker commented Apr 9, 2019

The code is essentially a standalone package run on the BTA output. It has a different release cycle and is developed by a different team. I think a separate repo for the ttbar directory could be a good idea and encourage it's upkeep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants