Remove CUDAService numberOfStreamsPerDevice as unsupported #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
reviewed
Mar 14, 2019
| @@ -52,7 +52,7 @@ class CUDAService { | |||
| bool enabled() const { return enabled_; } | |||
| // To be used in stream context when an edm::Stream is available | |||
| bool enabled(edm::StreamID streamId) const { return enabled(static_cast<unsigned int>(streamId)); } | |||
| bool enabled(unsigned int streamId) const { return enabled_ && (numberOfStreamsTotal_ == 0 || streamId < numberOfStreamsTotal_); } // to make testing easier | |||
| bool enabled(unsigned int streamId) const { return enabled_; } // to make testing easier | |||
There was a problem hiding this comment.
can we remove bool enabled(edm::StreamID streamId) and bool enabled(unsigned int streamId) ?
There was a problem hiding this comment.
Sure, they don't really make sense anymore.
Do not pass the stream id to cudaService->enabled(), since it is now used any more.
Remove the redundant `enabled()` overloads that accept the stream id, but do not use it.
fwyzard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
SwitchProducer(CUDA)(see #100) decides between CPU and GPU algorithm at the beginning of the job. This approach does not allow supporting thenumberOfStreamsPerDeviceparameter ofCUDAService. Therefore this PR suggests to remove that functionality fromCUDAService.If the feature is wanted back, the SwitchProducer would have to be enhanced to do the device type decisions event-by-event (see #281).