Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle Transformer sonic producer #45579

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

y19y19
Copy link
Contributor

@y19y19 y19y19 commented Jul 29, 2024

PR description:

This PR created a producer that allows particle transformer algorithm to be run on a remote triton server. It takes effect during AOD to MiniAOD step, no change in MiniAOD format output is expected.

PR validation:

This PR has been validated by comparing the inference softmax scores from the direct inference vs the inference made by triton server.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 29, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45579/41081

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

A new Pull Request was created by @y19y19 for master.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • RecoBTag/ONNXRuntime (reconstruction)

@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @jfernan2, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Martin-Grunewald, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @demuller, @fabiocos, @makortel, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

@cmsbuild
Copy link
Contributor

Pull request #45579 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @jfernan2, @mandrenguyen, @rappoccio can you please check and sign again.

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9063cf/40877/summary.html
COMMIT: df4fe14
CMSSW: CMSSW_14_1_X_2024-08-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45579/40877/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9063cf/40877/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9063cf/40877/git-merge-result

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3627495
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3627469
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 206 log files, 174 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+reconstruction

@kpedro88
Copy link
Contributor

@cms-sw/operations-l2 please check

@antoniovilela
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/RecoBTag-Combined#60

@antoniovilela
Copy link
Contributor

cms-data/RecoBTag-Combined#60 merged.
cmsdist tag PR: cms-sw/cmsdist#9372

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants