-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new test for reduced ProcessHistory #47032
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47032/43150
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
@Dr15Jones I'm wondering now if the Run transition check is enough, or should the test do a similar check for Lumi transition? |
probably a good idea to do the other test as well. Just to be thorough. |
08d828e
to
b063eb9
Compare
Now there are separate tests for new lumi and run transitions |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47032/43151
|
Pull request #47032 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
@cmsbuild, please test |
Pull request #47032 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
@cmsbuild, please test |
-1 Failed Tests: UnitTests Unit TestsI found 4 errors in the following unit tests: ---> test TestConfigDP_3 had ERRORS ---> test TestConfigDP_2 had ERRORS ---> test TestConfigDP_5 had ERRORS and more ... Comparison SummarySummary:
|
The DataProcessing unit test failures seem to be fixed with #47054 |
@cmsbuild, please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
Comparison differences are related to #47071 |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The existing test on reduced ProcessHistory (e.g. patch version number changes not leading to a Run transition) relies on old (4_2_X). This PR adds additional tests that use files created on the fly. In order to do that, this PR adds a new facility to
cms.Process
to mock the CMSSW version (hopefully in a way that is cumbersome and clear enough that it would not be used by accident). The new test checksFurthermore
TestPoolInput.sh
test script to new testsfillDescriptions()
toTestMergerResults
andRunLumiEventAnalyzer
Resolves cms-sw/framework-team#1100
PR validation:
Add test passes