Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new test for reduced ProcessHistory #47032

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Dec 30, 2024

PR description:

The existing test on reduced ProcessHistory (e.g. patch version number changes not leading to a Run transition) relies on old (4_2_X). This PR adds additional tests that use files created on the fly. In order to do that, this PR adds a new facility to cms.Process to mock the CMSSW version (hopefully in a way that is cumbersome and clear enough that it would not be used by accident). The new test checks

  • patch number version change does not lead to a Lumi or a Run transition
  • minor number version change leads to a Lumi and a Run transition

Furthermore

  • The first PR splits some tests off from the large TestPoolInput.sh test script to new tests
  • The second and third commits add fillDescriptions() to TestMergerResults and RunLumiEventAnalyzer

Resolves cms-sw/framework-team#1100

PR validation:

Add test passes

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47032/43150

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • FWCore/Framework (core)
  • FWCore/ParameterSet (core)
  • IOPool/Input (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@makortel
Copy link
Contributor Author

  • patch number version change does not lead to a Run transition

@Dr15Jones I'm wondering now if the Run transition check is enough, or should the test do a similar check for Lumi transition?

@Dr15Jones
Copy link
Contributor

I'm wondering now if the Run transition check is enough, or should the test do a similar check for Lumi transition?

probably a good idea to do the other test as well. Just to be thorough.

@makortel
Copy link
Contributor Author

Now there are separate tests for new lumi and run transitions

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47032/43151

@cmsbuild
Copy link
Contributor

Pull request #47032 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

Pull request #47032 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@makortel
Copy link
Contributor Author

makortel commented Jan 8, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

-1

Failed Tests: UnitTests
Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-197219/43687/summary.html
COMMIT: a969e1e
CMSSW: CMSSW_15_0_X_2025-01-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47032/43687/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 4 errors in the following unit tests:

---> test TestConfigDP_3 had ERRORS
---> test TestConfigDP_2 had ERRORS
---> test TestConfigDP_5 had ERRORS
and more ...

Comparison Summary

Summary:

@makortel
Copy link
Contributor Author

makortel commented Jan 9, 2025

The DataProcessing unit test failures seem to be fixed with #47054

@makortel
Copy link
Contributor Author

makortel commented Jan 9, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-197219/43703/summary.html
COMMIT: a969e1e
CMSSW: CMSSW_15_0_X_2025-01-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47032/43703/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3818730
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3818691
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

makortel commented Jan 9, 2025

Comparison differences are related to #47071

@makortel
Copy link
Contributor Author

makortel commented Jan 9, 2025

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend reduced history check to fake the release version
4 participants