Custom Phase-2 L1 Trigger NanoAOD #47178

artlbv · 2025-01-24T10:00:21Z

PR description:

This PR adds the Phase-2 L1 Trigger custom Nano version from a standalone repo https://github.com/cms-l1-dpg/Phase2-L1Nano/ to CMSSW. It allows storing the L1 and P2GT objects and also adds some gen collections used for Phase-2 Object and Menu studies.

This nano flavour is added to autoNANO as @Phase2L1DPG and also two upgrade workflows are implemented to test/run this nano after the full DigiTrigger chain after the complete L1:

.781 - produces NANO in addition to FEVTDEBUG
.782 - produces only NANO
I also added the Phase2L1DPGwithGen flavour which includes the Gen and some RECO tables used in the MenuTools of the L1 DPG which are normally contained in the MINIAOD.

Thus these wfs can be used for testing Phase-2 L1 PRs in future @aloeliger @slaurila @RobertJWard @jngadiub.

Some more documentation is in the DPGAnalysis/Phase2L1TNanoAOD/README.md.

PR validation:

Tested with the workflows 29634.781 and 29634.782 and manually with cmsDriver.py -s NANO:@Phase2L1DPG on 15X TTbar relvals.

…-l1-dpg/Phase2-L1Nano/

cmsbuild · 2025-01-24T10:00:53Z

cms-bot internal usage

cmsbuild · 2025-01-24T10:03:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47178/43417

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): [NGT] Implement NanoAOD ntuples production for HLT Muon objects #47069, CA Extension to strips #47090, add vertex trimming to the phase2 hlt tracking iterations #47113
- File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): [NGT] Implement NanoAOD ntuples production for HLT Muon objects #47069, HcalNano for MC #47102

cmsbuild · 2025-01-24T10:03:44Z

A new Pull Request was created by @artlbv for master.

It involves the following packages:

Configuration/PyReleaseValidation (upgrade, pdmv)
DPGAnalysis/L1TNanoAOD (l1, xpog)
DPGAnalysis/Phase2L1TNanoAOD (****)
PhysicsTools/NanoAOD (xpog)

The following packages do not have a category, yet:

DPGAnalysis/Phase2L1TNanoAOD
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@AdrianoDee, @Moanwar, @aloeliger, @cmsbuild, @DickyChant, @epalencia, @ftorrresd, @hqucms, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@AnnikaStein, @Martin-Grunewald, @fabiocos, @gpetruc, @makortel, @missirol, @mmusich, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

artlbv · 2025-01-24T10:10:28Z

I added the new package DPGAnalysis/Phase2L1TNanoAOD to l1,xpog in this PR: cms-sw/cms-bot#2420

artlbv · 2025-02-03T09:25:05Z

@aloeliger @Moanwar @hqucms @ftorrresd could you please either launch the tests and/or give me test rights?
thanks!

artlbv · 2025-02-05T15:08:34Z

@cmsbuild test parameters:

relvals_opt = --what upgrade
workflows = 29634.78, 29634.781, 29634.782

mmusich · 2025-02-05T15:22:06Z

test parameters:

relvals_opt = --what upgrade
workflows = 29634.78, 29634.781, 29634.782

you might want to check the right syntax to use here

aloeliger · 2025-02-05T15:32:58Z

test parameters:

workflows = 29634.78, 29634.781, 29634.782
relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,Run4

aloeliger · 2025-02-05T15:33:32Z

please test

cmsbuild · 2025-02-05T17:04:58Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d72480/44225/summary.html
COMMIT: ec8c2b5
CMSSW: CMSSW_15_0_X_2025-02-05-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47178/44225/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

29634.782

----- Begin Fatal Exception 05-Feb-2025 17:52:48 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'NANOAODSIMoutput_step'
   [2] Prefetching for module NanoAODOutputModule/'NANOAODSIMoutput'
   [3] Calling method for module NPUTablesProducer/'puTable'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Vertex>
Looking for module label: offlineSlimmedPrimaryVertices
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

29634.781

----- Begin Fatal Exception 05-Feb-2025 17:52:50 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'NANOAODSIMoutput_step'
   [2] Prefetching for module NanoAODOutputModule/'NANOAODSIMoutput'
   [3] Calling method for module NPUTablesProducer/'puTable'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Vertex>
Looking for module label: offlineSlimmedPrimaryVertices
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

NANO Comparison Summary

Summary:

You potentially added 198 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 89591
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 89591
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 22 files compared)
Checked 113 log files, 65 edm output root files, 23 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	3.110	3.110	0.000 ( +0.0% )	5.78	6.03	-4.2%	2.561	2.571
2500.002	3.227	3.227	0.000 ( +0.0% )	5.16	5.46	-5.3%	2.994	3.008
2500.003	3.167	3.167	0.000 ( +0.0% )	5.43	5.64	-3.8%	2.977	2.987
2500.011	1.642	1.642	0.000 ( +0.0% )	9.44	9.77	-3.4%	2.653	2.651
2500.012	2.180	2.180	0.000 ( +0.0% )	5.49	5.73	-4.2%	2.835	2.850
2500.013	1.997	1.997	0.000 ( +0.0% )	7.60	7.93	-4.2%	2.648	2.753
2500.021	0.022	0.022	0.000 ( +0.0% )	1.56	1.78	-12.4%	2.502	2.677
2500.022	0.022	0.022	0.000 ( +0.0% )	1.55	1.72	-9.7%	2.502	2.680
2500.023	0.022	0.022	0.000 ( +0.0% )	1.50	1.63	-8.0%	2.492	2.541
2500.024	0.022	0.022	0.000 ( +0.0% )	1.16	1.31	-11.1%	2.630	2.784
2500.031	0.035	0.035	0.000 ( +0.0% )	1.39	1.54	-9.7%	2.594	2.737
2500.032	0.036	0.036	0.000 ( +0.0% )	1.44	1.55	-6.8%	2.551	2.694
2500.033	0.037	0.037	0.000 ( +0.0% )	1.34	1.49	-10.1%	2.618	2.772
2500.034	0.036	0.036	0.000 ( +0.0% )	1.32	1.51	-12.5%	2.613	2.764
2500.101	2.850	2.850	0.000 ( +0.0% )	12.73	13.34	-4.5%	2.592	2.645
2500.111	1.469	1.469	0.000 ( +0.0% )	23.58	25.12	-6.2%	2.323	2.340
2500.112	1.889	1.889	0.000 ( +0.0% )	19.31	19.76	-2.3%	2.252	2.406
2500.131	0.750	0.750	0.000 ( +0.0% )	31.05	31.29	-0.8%	1.473	1.496
2500.201	2.679	2.679	0.000 ( +0.0% )	10.21	10.64	-4.0%	2.060	2.209
2500.211	1.836	1.836	0.000 ( +0.0% )	20.79	21.42	-3.0%	2.232	2.397
2500.212	2.233	2.233	0.000 ( +0.0% )	15.50	15.87	-2.3%	2.288	2.489
2500.221	2.115	2.115	0.000 ( +0.0% )	9.14	11.33	-19.3%	1.962	2.124
2500.222	3.487	3.487	0.000 ( +0.0% )	10.86	9.24	+17.5%	2.015	2.220
2500.223	9.490	9.490	0.000 ( +0.0% )	3.78	3.65	+3.5%	2.059	2.338
2500.224	6.604	6.604	0.000 ( +0.0% )	1.03	1.07	-4.1%	2.103	2.295
2500.225	6.652	6.652	0.000 ( +0.0% )	0.96	1.02	-5.4%	2.340	2.498
2500.226	3.180	3.180	0.000 ( +0.0% )	10.45	10.93	-4.4%	1.907	2.214
2500.227	1.442	1.442	0.000 ( +0.0% )	19.66	19.69	-0.1%	1.240	1.446
2500.228	3.996	3.996	0.000 ( +0.0% )	7.39	8.06	-8.3%	2.309	2.309
2500.231	1.512	1.512	0.000 ( +0.0% )	18.10	19.76	-8.4%	2.175	2.316
2500.232	2.493	2.493	0.000 ( +0.0% )	15.63	17.12	-8.7%	2.162	2.397
2500.233	4.986	4.986	0.000 ( +0.0% )	5.76	6.06	-4.9%	2.275	2.519
2500.234	3.919	3.919	0.000 ( +0.0% )	1.30	1.39	-6.6%	2.430	2.236
2500.235	3.950	3.950	0.000 ( +0.0% )	1.21	1.35	-10.0%	2.435	2.419
2500.236	2.282	2.282	0.000 ( +0.0% )	16.66	17.81	-6.4%	2.194	2.106
2500.237	1.018	1.018	0.000 ( +0.0% )	29.02	30.51	-4.9%	1.389	1.400
2500.238	2.469	2.469	0.000 ( +0.0% )	14.53	15.44	-5.9%	2.367	2.473
2500.241	9.404	9.404	0.000 ( +0.0% )	4.70	6.09	-22.7%	1.827	1.921
2500.242	10.331	10.331	0.000 ( +0.0% )	1.19	1.42	-16.1%	1.663	1.724
2500.243	2.712	2.712	0.000 ( +0.0% )	12.22	12.53	-2.4%	1.060	1.059
2500.244	486.016	486.016	0.000 ( +0.0% )	0.99	1.02	-3.5%	1.632	1.698
2500.245	826.413	826.413	0.000 ( +0.0% )	1.30	1.35	-3.6%	1.623	1.678
2500.251	645.314	645.314	0.000 ( +0.0% )	1.33	1.54	-13.9%	1.781	1.494
2500.301	0.021	0.021	0.000 ( +0.0% )	1.30	1.72	-24.5%	2.792	2.789
2500.311	0.036	0.036	0.000 ( +0.0% )	1.43	1.58	-9.9%	2.737	2.741
2500.901	1.819	1.819	0.000 ( +0.0% )	32.80	43.65	-24.9%	1.443	1.448
2500.902	1.665	1.665	0.000 ( +0.0% )	39.42	44.70	-11.8%	1.338	1.338
2500.911	14.345	14.345	0.000 ( +0.0% )	6.30	8.39	-24.9%	1.088	1.085
2500.912	0.240	0.240	0.000 ( +0.0% )	2.86	2.58	+10.8%	0.847	0.845
2500.913	0.110	0.110	0.000 ( +0.0% )	1.64	2.48	-34.0%	0.850	0.851

…eadme

artlbv · 2025-02-06T11:32:07Z

I modified the Phase2L1DPG to not include the Gen and Reco (PV) tables, as the Reco is missing from the workflows I tested here. Instead I added Phase2L1DPGwithGen which includes these tables used in the MenuTools of the L1 DPG.

I also added the new wfs .781 and .782 to the PyRelVal readme.

cmsbuild · 2025-02-06T11:33:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47178/43589

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): [NGT] Implement NanoAOD ntuples production for HLT Muon objects #47069, add vertex trimming to the phase2 hlt tracking iterations #47113
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): [NGT] Implement NanoAOD ntuples production for HLT Muon objects #47069, CA Extension to strips #47090, add vertex trimming to the phase2 hlt tracking iterations #47113
- File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): [NGT] Implement NanoAOD ntuples production for HLT Muon objects #47069

cmsbuild · 2025-02-06T11:34:22Z

Pull request #47178 was updated. @AdrianoDee, @Moanwar, @aloeliger, @cmsbuild, @DickyChant, @epalencia, @ftorrresd, @hqucms, @miquork, @srimanob, @subirsarkar can you please check and sign again.

artlbv · 2025-02-06T11:36:02Z

@cmsbuild please test

cmsbuild · 2025-02-07T08:33:13Z

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

artlbv added 8 commits January 23, 2025 22:19

Add Phase2 L1Nano as separate DPG Package from https://github.com/cms…

06b48dc

…-l1-dpg/Phase2-L1Nano/

Add Phase2 L1 nano into autoNANO

1cb88c3

Add Phase2 L1 Nano workflows

1143c02

Commen out HPSTaus from Ph2L1nano

1f5ca7c

Fix P2L1nano wfs

87866ba

Moved P2GT results converter to P2L1nano folder

1f358fe

Clean up and update readme

e4be0be

Some more cleanup

ec8c2b5

cmsbuild added this to the CMSSW_15_0_X milestone Jan 24, 2025

cmsbuild added l1-pending pending-signatures tests-pending orp-pending new-package-pending pdmv-pending upgrade-pending code-checks-pending xpog-pending labels Jan 24, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 24, 2025

artlbv mentioned this pull request Jan 24, 2025

Assign DPGAnalysis/Phase2L1TNanoAOD to L1 and XPOG cms-sw/cms-bot#2420

Merged

This was referenced Jan 27, 2025

[NGT] Implement NanoAOD ntuples production for HLT Muon objects #47069

Open

add vertex trimming to the phase2 hlt tracking iterations #47113

Open

CA Extension to strips #47090

Draft

cmsbuild removed the new-package-pending label Feb 3, 2025

cmsbuild added tests-started and removed tests-approved labels Feb 5, 2025

cmsbuild added tests-rejected and removed tests-started labels Feb 5, 2025

artlbv added 2 commits February 6, 2025 12:25

Fix default L1Nano sequence to not use RECO and Gen objects, update r…

d800a4a

…eadme

Add new Phase2L1Nano wfs to PyRelVal README

b6b78f4

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Feb 6, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 6, 2025

cmsbuild added tests-started and removed tests-pending labels Feb 6, 2025

cmsbuild modified the milestones: CMSSW_15_0_X, CMSSW_15_1_X Feb 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom Phase-2 L1 Trigger NanoAOD #47178

Custom Phase-2 L1 Trigger NanoAOD #47178

artlbv commented Jan 24, 2025 •

edited

Loading

cmsbuild commented Jan 24, 2025 •

edited

Loading

cmsbuild commented Jan 24, 2025

cmsbuild commented Jan 24, 2025

artlbv commented Jan 24, 2025

artlbv commented Feb 3, 2025

artlbv commented Feb 5, 2025

mmusich commented Feb 5, 2025

aloeliger commented Feb 5, 2025

aloeliger commented Feb 5, 2025

cmsbuild commented Feb 5, 2025

artlbv commented Feb 6, 2025

cmsbuild commented Feb 6, 2025

cmsbuild commented Feb 6, 2025

artlbv commented Feb 6, 2025

cmsbuild commented Feb 7, 2025

Custom Phase-2 L1 Trigger NanoAOD #47178

Are you sure you want to change the base?

Custom Phase-2 L1 Trigger NanoAOD #47178

Conversation

artlbv commented Jan 24, 2025 • edited Loading

PR description:

PR validation:

cmsbuild commented Jan 24, 2025 • edited Loading

cmsbuild commented Jan 24, 2025

cmsbuild commented Jan 24, 2025

artlbv commented Jan 24, 2025

artlbv commented Feb 3, 2025

artlbv commented Feb 5, 2025

mmusich commented Feb 5, 2025

aloeliger commented Feb 5, 2025

aloeliger commented Feb 5, 2025

cmsbuild commented Feb 5, 2025

RelVals

NANO Comparison Summary

artlbv commented Feb 6, 2025

cmsbuild commented Feb 6, 2025

cmsbuild commented Feb 6, 2025

artlbv commented Feb 6, 2025

cmsbuild commented Feb 7, 2025

artlbv commented Jan 24, 2025 •

edited

Loading

cmsbuild commented Jan 24, 2025 •

edited

Loading