-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kt smearing for gammaUPC #47183
base: CMSSW_10_6_X
Are you sure you want to change the base?
kt smearing for gammaUPC #47183
Conversation
A new Pull Request was created by @michael-pitt for CMSSW_10_6_X. It involves the following packages:
@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@michael-pitt : Considering that the bash script allows to input parameters, one could add a parameter to retrieve the "beams" parameter used by the kT smearing python script, which would generalize this to both pp and heavy ions. In addition, by using an input parameter, one would not need to create a separate "run_tarball_cvmfs_....sh" script, since if the parameter is null then that would not apply the kT smearing. So my suggestion would be to add:
|
Hi I chatted with @stahlleiton on this, there is actually a e.g.
This command will run the script In this way we don't have to touch the big script. What do you think? |
Hi @DickyChant Thank you for your suggestion, I like it very much! I moved the file to externalLHEProducer = cms.EDProducer("ExternalLHEProducer",
...
postGenerationCommand = cms.untracked.vstring('gamma-UPC_lhe_ktsmearing_UPC.py', '--file=cmsgrid_final.lhe', '--out=cmsgrid_final.lhe', '--beams=p p')
) I tested the code with this fragment, and it seems to be working. We also have a Fortran version of this script, which runs much faster, but I don't know how to add |
Hi, (comment here as gamma-UPC author). Regarding the kT smearing, the Fortran code is much faster than the python script. For large LHE files it really makes sense to use the fortran code post-generation. thanks, david |
Dear @bbilin @lviliani @menglu21 @mkirsano I've cleaned up the code and produced kT-smeared samples using Python script. The Fortran code requires some work to be integrated into CMSSW. Since we should have a single script for kT smearing and the Fortran will take some time I would propose to merge the current RP so we can ask for central production of these samples. @denterria: We can later on (if needed) to integrate and replace the python version with the Fortran code. Regards, |
@cmsbuild please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
PR description:
This is a copy of
run_generic_tarball_cvmfs.sh
with additional pT smearing for processes involving elastic photons prodiced by Madgraph or gammaUPCPR validation:
This code was tested in production chain with 10_6_46
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: