-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clang-tidy test to make sure it process header file too #47203
Update clang-tidy test to make sure it process header file too #47203
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47203/43474 |
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test though tests should fail as we need cms-sw/cmsdist#9652 |
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test test-scram-code-checks had ERRORS Comparison SummarySummary:
|
REMINDER @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmsdist#9652, please check if they should be merged together |
please test latest IB has new build rules so unit test should pass |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
@smuzaffar Is this PR good to go? |
@makortel , yes this is good to go in |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Improved clang-tidy and clang-format tests. Now these tests make sure that cmssw header files are also properly processed