[JME,Nano] Refactor constituents table, add GloParT WvsQCD score #47206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tuents. Move jet constituents set up to its own file. Add functions to add AK4 jet and genjets constituents for private production
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47206/43477
|
|
A new Pull Request was created by @nurfikri89 for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable nano |
|
please test |
|
+1 Size: This PR adds an extra 56KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
|
label btv |
|
assign btv-pog |
|
New categories assigned: btv-pog @mondalspandan,@SWuchterl you have been requested to review this Pull request/Issue and eventually sign? Thanks |
hqucms
reviewed
Jan 31, 2025
| @@ -73,6 +73,8 @@ | |||
| globalParT3_TopbWmv = Var("bDiscriminator('pfGlobalParticleTransformerAK8JetTags:probTopbWmv')",float,doc="Mass-decorrelated GlobalParT-3 Top->bWmv score",precision=10), | |||
| globalParT3_TopbWtauhv = Var("bDiscriminator('pfGlobalParticleTransformerAK8JetTags:probTopbWtauhv')",float,doc="Mass-decorrelated GlobalParT-3 Top->bWtauhv score",precision=10), | |||
| globalParT3_QCD = Var("bDiscriminator('pfGlobalParticleTransformerAK8JetTags:probQCD')",float,doc="Mass-decorrelated GlobalParT-3 QCD score.",precision=10), | |||
| globalParT3_WvsQCD = Var("?bDiscriminator('pfGlobalParticleTransformerAK8JetTags:probXqq')+bDiscriminator('pfGlobalParticleTransformerAK8JetTags:probXcs')+bDiscriminator('pfGlobalParticleTransformerAK8JetTags:probQCD')>0?(bDiscriminator('pfGlobalParticleTransformerAK8JetTags:probXqq')+bDiscriminator('pfGlobalParticleTransformerAK8JetTags:probXcs'))/(bDiscriminator('pfGlobalParticleTransformerAK8JetTags:probXqq')+bDiscriminator('pfGlobalParticleTransformerAK8JetTags:probXcs')+bDiscriminator('pfGlobalParticleTransformerAK8JetTags:probQCD')):-1", | |||
There was a problem hiding this comment.
Isn't this redundant as probXqq, probXcs and probQCD are already stored?
|
|
||
| process.selectedGenJetAK8Constituents = cms.EDFilter("PATPackedGenParticlePtrSelector", | ||
| src = cms.InputTag("genJetAK8Constituents", "constituents"), | ||
| cut = cms.string(genJetConstCut) |
There was a problem hiding this comment.
Suggested change
| cut = cms.string(genJetConstCut) | |
| cut = cms.string(genJetAK8ConstCut) |
| name = cms.string(process.genJetTable.name.value()+"GenPartCand"), | ||
| candIdxName = cms.string("genPartCandIdx"), | ||
| candIdxDoc = cms.string("Index in the GenPartCand table"), | ||
| candidates = pfCandidatesTable.src, |
There was a problem hiding this comment.
Suggested change
| candidates = pfCandidatesTable.src, | |
| candidates = process.genPartCandidatesTable.src, |
| name = cms.string(process.genJetAK8Table.name.value()+"GenPartCand"), | ||
| candIdxName = cms.string("genPartCandIdx"), | ||
| candIdxDoc = cms.string("Index in the GenPartCand table"), | ||
| candidates = pfCandidatesTable.src, |
There was a problem hiding this comment.
Suggested change
| candidates = pfCandidatesTable.src, | |
| candidates = process.genPartCandidatesTable.src, |
| candidates = pfCandidatesTable.src, | ||
| jets = process.genJetAK8Table.src, | ||
| jetCut = process.genJetAK8Table.cut, | ||
| jetConstCut = process.selectedGenJetConstituents.cut |
There was a problem hiding this comment.
Suggested change
| jetConstCut = process.selectedGenJetConstituents.cut | |
| jetConstCut = process.selectedGenJetAK8Constituents.cut |
| process = SaveGenJetConstituents(process,True,False) | ||
| return process | ||
| def SaveGenJetAK8Constituents(process): | ||
| process = SaveGenJetConstituents(process,True,False) |
There was a problem hiding this comment.
Suggested change
| process = SaveGenJetConstituents(process,True,False) | |
| process = SaveGenJetConstituents(process,False,True) |
Or better:
Suggested change
| process = SaveGenJetConstituents(process,True,False) | |
| process = SaveGenJetConstituents(process, addGenJetConst=False, addGenJetAK8Const=True) |
| ) | ||
| process.genjetConstituentsTask.add(process.selectedGenJetAK8Constituents) | ||
|
|
||
| if addGenJetConst or addGenJetConst: |
There was a problem hiding this comment.
Suggested change
| if addGenJetConst or addGenJetConst: | |
| if addGenJetConst or addGenJetAK8Const: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR refactors the PF constituents table by putting the relevant modules in a dedicated cff file (
jetsConstituents_cff.py). The main purpose is to streamline the modules used for storing PF constituents information for btvNano. Another PR on revamping btvNano will soon follow. This refactoring will also make it easier for NanoAOD private production with more constituents from other jet collections. In the cff file, I have added two customization functions that can be used to add AK4 and gen-jet constituents. Additionally, the GloParTWvsQCDbinarized score is added to theFatJettable.PR validation:
runTheMatrix.py -l limited -i all --ibeoswith the exception of a few workflows which failed because of missing relval input files.runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034