-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sources now have independent ProductRegistry #47213
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47213/43495
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
5ed4296
to
83520d7
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47213/43496
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Sources can now update their ProductRegistry without affecting the rest of the system. The system will pick up the changes when they are needed.
83520d7
to
a52b578
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47213/43498
|
Pull request #47213 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
please test |
-1 Failed Tests: HeaderConsistency UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 1 errors in the following unit tests: ---> test TestIOPoolInputNoParentDictionary had ERRORS Comparison SummarySummary:
|
PR description:
Sources can now update their ProductRegistry without affecting the rest of the system. The system will pick up the changes when they are needed.
PR validation:
Framework code compiles and framework related unit tests pass.
resolves cms-sw/framework-team#1207