Monitor quality of unpacked FED data with a dedicated SoA

[pfs]

PR description:

In recent data taking with HGCAL system validation we have experienced data corruption at FED level. While this may be somehow expected in this early stage of commissioning / construction it's worthwhile having in release some monitoring for when this happens.
In addition the HGCAL unpacker was already filling a series of "quality flags" which were not propagated elsewhere and could not be monitored.
In this PR we introduce a new SoA DataFormats/HGCalDigi/interface/HGCalFEDPacketInfoSoA.h which is filled with basic flags that indicate whether the data is normal or as errors. The SoA is expected to be furthermore useful in developing a fast error DQM for HGCAL system validation setups

PR validation:

This PR has been validated with real data acquired with a six module stand. Should not have any impact on the CMSSW simulation or data workflows for the time being.

@IzaakWN @yulunmiao @hqucms

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47451/43862

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47451/43862/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47451/43862/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[pfs]

assign hgcal-dpg

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47451/43864

[cmsbuild]

New categories assigned: hgcal-dpg

@cseez,@felicepantaleo,@pfs,@rovere you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Pull Request was created by @pfs for master.

It involves the following packages:

• DataFormats/HGCalDigi (simulation, upgrade)
• EventFilter/HGCalRawToDigi (upgrade, reconstruction)

@Moanwar, @civanch, @cmsbuild, @cseez, @felicepantaleo, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @pfs, @rovere, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[pfs]

please test

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b13b7/44656/summary.html
COMMIT: 97c2c68
CMSSW: CMSSW_15_1_X_2025-02-25-1200/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47451/44656/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3920300
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3920277
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

assign heterogeneous

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47451/43925

[cmsbuild]

Pull request #47451 was updated. @Moanwar, @civanch, @cmsbuild, @cseez, @felicepantaleo, @fwyzard, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @pfs, @rovere, @srimanob, @subirsarkar can you please check and sign again.

[pfs]

please test

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b13b7/44748/summary.html
COMMIT: 5e9be3b
CMSSW: CMSSW_15_1_X_2025-02-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47451/44748/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 17 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3920300
• DQMHistoTests: Total failures: 66
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3920214
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: found differences in 1 / 47 workflows

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47451/43930

[cmsbuild]

Pull request #47451 was updated. @Moanwar, @civanch, @cmsbuild, @cseez, @felicepantaleo, @fwyzard, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @pfs, @rovere, @srimanob, @subirsarkar can you please check and sign again.

[pfs]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b13b7/44768/summary.html
COMMIT: e96b92c
CMSSW: CMSSW_15_1_X_2025-03-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47451/44768/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 13 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3920300
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3920271
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found