Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New BTV Monitor #47472

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New BTV Monitor #47472

wants to merge 2 commits into from

Conversation

aniketkhanal
Copy link
Contributor

PR description:

This PR adds a new analyzer for BTV HLT DQM. Currently, BTV uses a clone of TopMonitor, which makes it difficult to directly make changes. The new BTVMonitor uses "pat" objects instead of "reco" objects previously so all the information can be read from miniAOD level.

Instead of having a new folder for each b-tagging algorithm (which is the case currently), we now have all the b-tagging score histograms in one folder, thus reducing duplicates. The PR also adds b-tagging scores from the UParT tagger for AK4 jets, while keeping all the previously used taggers (DeepJet and ParticleNet)

PR validation:

These changes pass all the basic tests suggested in CMSSW PR instructions. Furthermore, the changes are visible in the offline DQM GUI histograms for workflow 16834.0.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47472/43904

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aniketkhanal for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @cericeci, @jhgoh, @missirol, @mmusich, @mtosi, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2025

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c147e2/44762/summary.html
COMMIT: 79f87ea
CMSSW: CMSSW_15_1_X_2025-03-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47472/44762/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 136.7801136.7801_RunHLTPhy2017B_AOD/step2_RunHLTPhy2017B_AOD.log
  • 136.7802136.7802_RunHLTPhy2017B_AODextra/step2_RunHLTPhy2017B_AODextra.log
  • 1040.01040.0_RunZeroBias2017F/step2_RunZeroBias2017F.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • You potentially removed 13 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3911014
  • DQMHistoTests: Total failures: 1763
  • DQMHistoTests: Total nulls: 1037
  • DQMHistoTests: Total successes: 3908194
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -6492.132 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 145.014,... ): -654.212 KiB HLT/BTV
  • DQMHistoSizes: changed ( 16834.0,... ): -629.218 KiB HLT/BTV
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants