-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FDT Dockerfile for FDT and FDT Agent #23
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 dirs are pretty much equal, only difference is:
CMD ["java", "-jar", "fdt.jar", "-p", "54321", "-autoport", "-portrange", "100", "-agent"]
vs
CMD ["java", "-jar", "fdt.jar", "-p", "54321"]
So I would add everything inside fdt/ directory and have 2 files:
Dockerfile-agent
Dockerfile
and github workflows can build one or another.
@@ -0,0 +1,87 @@ | |||
name: Docker Image Build For FDT Agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to replace name. Same name will confuse github actions.
@@ -0,0 +1,5 @@ | |||
for did in `docker images | grep hepgui | awk '{print $3}' | uniq`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant file. delete
@@ -0,0 +1,5 @@ | |||
source ../environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant file. delete
No description provided.