Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds M48A4 to the character creation loadout #121

Closed
wants to merge 4 commits into from

Conversation

Merrgear
Copy link
Contributor

About the pull request

Pretty self explanatory, M48A4 is now in the character creation pointbuy

Explain why it's good for the game

Muh two world wars! and i just think its neat. Allows a little more character to the marines choice of sidearms. +

Changelog

🆑 Merrgear2
add: Adds the M48A4 Service Pistol to the loadout pointbuy
🆑

Copy link
Contributor

@FslashN FslashN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little too much sauce for a flavor gun as it is right now.

storage_slots = 7

/obj/item/storage/box/M48A4_loadout/fill_preset_inventory()
new /obj/item/weapon/gun/pistol/m1911/socom(src)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like having the SOCOM variant available as a flavor gun; it's got several attachments and is meant to be better than the standard. I would make this the regular 1911, which is an iconic gun I can see people would want for flavor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the SOCOM 1911, as i recall has no stat changes from the normal 1911. the one in the PR isnt the outfitted one with the RDS suppressor and laser sight. and the main reason i chose the SOCOM one is the regular 1911 looks so fucking ugly.
image
if there was an updated to not be shit sprite for the base 1911 i wouldve used that one, cause functionally they are the same

Copy link
Contributor

@FslashN FslashN Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SOCOM variant is a little different stat wise; slightly more accurate with less scatter at the expense of a slightly lower damage multiplier from what I'm seeing.

You could add a "custom" variant that is just a reskinned 1911 with a new description, just like the other flavor guns.


/obj/item/storage/box/M48A4_loadout/fill_preset_inventory()
new /obj/item/weapon/gun/pistol/m1911/socom(src)
new /obj/item/ammo_magazine/pistol/m1911(src)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Six mags is quite a few. I think two extra mags would be fine given that you can stuff the gun and the mags into a shoulder holster, just like the VP78.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just took the base kit you get from req blackmarket and put it into something that fits into the backpack that i think was meant to be used in a pistol belt. only around 42 rounds now that the 1911 mag gives 7 instead of 14 rounds, but i can change that

@FslashN FslashN marked this pull request as draft February 21, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants