Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shower sounds #141

Merged
merged 3 commits into from
Mar 12, 2024
Merged

shower sounds #141

merged 3 commits into from
Mar 12, 2024

Conversation

AndroBetel
Copy link
Contributor

@AndroBetel AndroBetel commented Mar 8, 2024 •
edited
Loading

@AndroBetel AndroBetel requested a review from fira as a code owner March 8, 2024 18:56
@github-actions github-actions bot added the Sound label Mar 8, 2024
morrowwolf
morrowwolf requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@morrowwolf morrowwolf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link the PR on Tau Ceti that added it (or at least a commit) so we can confirm the sound source.

Oh and normalize the sounds to -8 dbs please. You can use audacity and it's real easy.

@morrowwolf morrowwolf marked this pull request as draft March 11, 2024 19:17
@AndroBetel
Copy link
Contributor Author

should be good now

@AndroBetel AndroBetel marked this pull request as ready for review March 11, 2024 19:43
@morrowwolf
Copy link
Member

People better not be weird with this 👀

@morrowwolf morrowwolf marked this pull request as draft March 11, 2024 19:55
@AndroBetel AndroBetel marked this pull request as ready for review March 11, 2024 20:10
@morrowwolf morrowwolf merged commit 104a1b4 into cmss13-devs:master Mar 12, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrowwolf morrowwolf morrowwolf approved these changes

@fira fira Awaiting requested review from fira fira is a code owner

Assignees
No one assigned
Labels
Sound
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndroBetel @morrowwolf