Adding additional rounds to the smart gun. Round two. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower damage from the boyars (Still a strong anti-armor gun.)
Lower damage from the boyars (Still a strong anti-armor gun.)
This reverts commit 4c70688.
…tile for build up. Changed the smoke grenades to a flare launcher for tank visibility. Increased damage multipliers on tank to factor in it's armor attachments a little better. Turned the Cupola from burst fire to full auto Increased the firing arcs slightly on all secondary tank weapons. Changed support modules on all tank loadouts.
AndroBetel
requested changes
Mar 12, 2024
| @@ -13,6 +13,12 @@ | |||
| reload_sound = 'sound/weapons/handling/gun_sg_reload.ogg' | |||
| unload_sound = 'sound/weapons/handling/gun_sg_unload.ogg' | |||
| current_mag = /obj/item/ammo_magazine/smartgun | |||
|
|
|||
| accepted_ammo = list( | |||
There was a problem hiding this comment.
yeah, no, that won't work.
SG uses var/datum/ammo/ammo_primary and var/datum/ammo/ammo_secondary to define what ammo to shoot, so you might want to somehow tie these vars to loaded mags
There was a problem hiding this comment.
This is correct. You could also remove the ammo switching (the toggle function) all-together, as it doesn't make any logical sense anyway. It's a PvP holdout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
It adds additional ammo types to be loaded into the smart gun.
Testing has been done on local. It works.
Explain why it's good for the game
So mostly a niche use. But I am big fan of the holorounds and I think that would be a cool thing GM's can bust out. Sometimes i run HVT ops and I usually give the marines extra goodies. It'd be cool if we could give something the SG's could practically use too. Overall I don't think it'll be that much of a change as it's ultimately up to GM's discretion but a fun potential option.
Changelog
🆑
add: Added the ability for the smartgun to take both holo and dirty mags.
/:cl: