-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote Outpost Gamemode + New Map + GM Tools #180
Closed
Closed
Changes from 79 commits
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
cfe676f
Blackstone Bridge (Whiskey Outpost Re-Imagined) Part I
FslashN 8a2ad1d
Merge remote-tracking branch 'upstream/master' into Whiskey-Outpost-Mod
FslashN 46c14d0
Part II of WO Reimagining
FslashN 03cbdd7
Update to Appease the Linter Gods
FslashN 6cf6867
More Linter Fxies
FslashN 97f2c17
A Few Minor Changes
FslashN 85bbd6a
Fix, maybe?
FslashN eb11fa2
Linters, Part Infinity
FslashN 30c0afc
Nukes Stickyban
FslashN 4b6aad4
Mapping Fixes
FslashN 2a31d86
Another Small Fix
FslashN 82e71f8
Fixes and Updates
FslashN 640ad0e
Fixes to Squad Lead Sorting
FslashN c19527d
Linters Fix
FslashN a904032
Merge remote-tracking branch 'upstream/master' into Whiskey-Outpost-Mod
FslashN 2429cea
Polish, Additional Fixes, Faction Refactor
FslashN a55118c
Merge remote-tracking branch 'upstream/master' into Whiskey-Outpost-Mod
FslashN cca6851
Minor Fixes and Changes
FslashN 1ecde0b
Fixes From Test
FslashN 1effe1d
Final Fixes/Adjustments for Blackstone
FslashN 1c86786
Merge remote-tracking branch 'upstream/master' into Whiskey-Outpost-Mod
FslashN d51fe9f
Linter Fix
FslashN 2e51912
Few Minor Fixes from Last Playtest
FslashN 8abf60f
String Fix for Civilian Title
FslashN ea783e2
Manifest Sorting Fix
FslashN 54c78cf
Linters Fix
FslashN d283985
Another Final Round of Adjustments
FslashN 4bac7b7
Merge remote-tracking branch 'upstream/master' into Whiskey-Outpost-Mod
FslashN 5581ebb
UPP Premade Sentry Update
FslashN 899fe1d
Merge branch 'master' into Whiskey-Outpost-Mod
FslashN 6a0e416
Merge remote-tracking branch 'upstream/master' into Whiskey-Outpost-Mod
FslashN a81aecb
Merge branch 'master' into Whiskey-Outpost-Mod
AndroBetel b363cf5
Merge remote-tracking branch 'upstream/master' into Whiskey-Outpost-Mod
FslashN 2475c1d
Merge remote-tracking branch 'upstream/master' into Whiskey-Outpost-Mod
FslashN b2079b5
Even More Updates to Roles, Map, Etc
FslashN 9293e12
Merge remote-tracking branch 'upstream/master' into Whiskey-Outpost-Mod
FslashN 1428625
Merge branch 'Whiskey-Outpost-Mod' of https://github.com/FslashN/CMSS…
FslashN 3bfe25f
Compile Fix
FslashN 86877b6
Fixes Initialize()
FslashN 1536ab5
Style + Consistency + Comments Update Part I
FslashN cf858ce
Merge remote-tracking branch 'upstream/master' into Whiskey-Outpost-Mod
FslashN fe46f20
Linter Fix for scenario.dm
FslashN 3d8bb40
Another Linter Fix
FslashN 0660f40
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN 4c0c865
Update code/modules/cm_marines/equipment/maps.dm
FslashN 00bd225
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN d285d2a
Update code/modules/vehicles/van/van.dm
FslashN cf4ade7
Update code/modules/vehicles/van/van.dm
FslashN 9adebc1
Update code/modules/vehicles/van/van.dm
FslashN 1a414f9
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN 8380043
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN 069ca36
Update code/datums/datacore.dm
FslashN 2372cb3
Update code/datums/datacore.dm
FslashN 502f3b2
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN c628677
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN 8f2f346
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN 6a73fd4
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN f6ddb1a
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN 18b1d3a
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN 95f8ab0
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN f41cfa6
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN a0d89b1
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN c571d66
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN 1bec2fa
Update code/modules/admin/game_master/extra_buttons/map_manipulation_…
FslashN 377897d
Update tgui/packages/tgui/interfaces/MapManipulation.js
FslashN 604d255
Update tgui/packages/tgui/interfaces/MapManipulation.js
FslashN b6e714d
Update tgui/packages/tgui/interfaces/MapManipulation.js
FslashN 2e3027b
Update tgui/packages/tgui/interfaces/MapManipulation.js
FslashN 5431396
Update tgui/packages/tgui/interfaces/MapManipulation.js
FslashN fba6254
Update tgui/packages/tgui/interfaces/MapManipulation.js
FslashN ebed825
Update tgui/packages/tgui/interfaces/MapManipulation.js
FslashN 5f54c66
Update tgui/packages/tgui/interfaces/MapManipulation.js
FslashN 35e3672
Comment Changes Part II
FslashN 4c7acfc
PR Port and Bitfield Changes
FslashN 2bc22ff
Changes per Changes Requested Part III
FslashN 49c9fcc
Merge remote-tracking branch 'upstream/master' into Whiskey-Outpost-Mod
FslashN 4874962
Merge branch 'master' into Whiskey-Outpost-Mod
FslashN 084900d
Small Fix for Blackstone
FslashN 2c7bf57
Merge branch 'Whiskey-Outpost-Mod' of https://github.com/FslashN/CMSS…
FslashN 23898b2
Merge branch 'master' into Whiskey-Outpost-Mod
DexterDude a003d31
Merge branch 'master' of https://github.com/PvE-CMSS13/PvE-CMSS13 int…
AndroBetel d654abd
Update colonialmarines.dme
AndroBetel 0726b25
Merge branch 'Whiskey-Outpost-Mod' of https://github.com/FslashN/CMSS…
AndroBetel 2ddb15d
conflicts?
AndroBetel 8ba72de
conflict2
AndroBetel 54c5105
Merge branch 'master' of https://github.com/PvE-CMSS13/PvE-CMSS13 int…
AndroBetel 90ba50a
Update colonialmarines.dme
AndroBetel fcf02c8
conflict
AndroBetel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
#define get_job_playtime(client, job) (client.player_data? LAZYACCESS(client.player_data.playtimes, job)? client.player_data.playtimes[job].total_minutes MINUTES_TO_DECISECOND : 0 : 0) | ||
#define GET_MAPPED_ROLE(title) (RoleAuthority?.role_mappings[title] ? RoleAuthority.role_mappings[title] : RoleAuthority.roles_by_name[title]) | ||
#define GET_DEFAULT_ROLE(title) (RoleAuthority?.default_roles[title] ? RoleAuthority.default_roles[title] : title) | ||
#define GET_SQUAD_ROLE_MAP(title) (RoleAuthority?.roles_for_squad[title] || title) | ||
#define GET_MANIFEST_ROLES (RoleAuthority? RoleAuthority.manifest_roles | RoleAuthority.manifest_append : list()) | ||
|
||
// Squad name defines | ||
#define SQUAD_MARINE_1 "Sun Riders" | ||
|
@@ -10,6 +10,8 @@ | |
#define SQUAD_MARINE_5 "Echo" | ||
#define SQUAD_MARINE_CRYO "Foxtrot" | ||
#define SQUAD_MARINE_INTEL "Intel" | ||
#define SQUAD_USCM_GROUND_1 "Copperheads" | ||
#define SQUAD_USCM_GROUND_2 "Rattlesnakes" | ||
#define SQUAD_SOF "SOF" | ||
#define SQUAD_CBRN "CBRN" | ||
#define SQUAD_UPP "Red Dawn" | ||
|
@@ -24,21 +26,7 @@ | |
#define JOB_SQUAD_TEAM_LEADER "Squad Sergeant" | ||
#define JOB_SQUAD_SMARTGUN "Smartgunner" | ||
#define JOB_SQUAD_ROLES /datum/timelock/squad | ||
#define JOB_SQUAD_ROLES_LIST list(JOB_SQUAD_MARINE, JOB_SQUAD_LEADER, JOB_SQUAD_ENGI, JOB_SQUAD_MEDIC, JOB_SQUAD_SPECIALIST, JOB_SQUAD_SMARTGUN, JOB_SQUAD_TEAM_LEADER) | ||
|
||
#define JOB_SQUAD_MARINE_UPP "UPP Rifleman" | ||
#define JOB_SQUAD_LEADER_UPP "UPP Platoon Sergeant" | ||
#define JOB_SQUAD_MEDIC_UPP "UPP Sanitar" | ||
#define JOB_SQUAD_TEAM_LEADER_UPP "UPP Squad Sergeant" | ||
#define JOB_SQUAD_SMARTGUN_UPP "UPP Machinegunner" | ||
#define JOB_SO_UPP "UPP Platoon Commander" | ||
|
||
#define JOB_SQUAD_TEAM_LEADER_FORECON "FORECON Assistant Squad Leader" | ||
#define JOB_SQUAD_LEADER_FORECON "FORECON Squad Leader" | ||
#define JOB_SQUAD_MEDIC_FORECON "FORECON Squad Corpsman" | ||
#define JOB_SQUAD_RTO "Radio Telephone Operator" | ||
#define JOB_SQUAD_MARINE_FORECON "FORECON Rifleman" | ||
#define JOB_SQUAD_SMARTGUN_FORECON "FORECON Smartgunner" | ||
#define JOB_SQUAD_ROLES_LIST list(JOB_SQUAD_LEADER, JOB_SQUAD_TEAM_LEADER, JOB_SQUAD_ENGI, JOB_SQUAD_MEDIC, JOB_SQUAD_SPECIALIST, JOB_SQUAD_SMARTGUN, JOB_SQUAD_MARINE) | ||
|
||
var/global/list/job_squad_roles = JOB_SQUAD_ROLES_LIST | ||
|
||
|
@@ -152,6 +140,32 @@ var/global/list/job_command_roles = JOB_COMMAND_ROLES_LIST | |
. = ..(L);\ | ||
} | ||
|
||
//-------------USCM Outpost roles--------------- | ||
|
||
#define JOB_USCM_GROUND_CO "Outpost Commanding Officer" | ||
#define JOB_USCM_GROUND_AO "Outpost Adjunct Officer" | ||
#define JOB_USCM_GROUND_SYNTH "Outpost Maint. Synthetic" | ||
|
||
#define JOB_USCM_GROUND_SQUAD_LEADER "Outpost Plt. Sergeant" | ||
#define JOB_USCM_GROUND_SQUAD_TEAM_LEADER "Outpost Sqd. Sergeant" | ||
#define JOB_USCM_GROUND_SQUAD_MEDIC "Outpost Corpsman" | ||
#define JOB_USCM_GROUND_SQUAD_SPECIALIST "Outpost Specialist" | ||
#define JOB_USCM_GROUND_SQUAD_SMARTGUNNER "Outpost Smartgunner" | ||
#define JOB_USCM_GROUND_SQUAD_MARINE "Outpost Rifleman" | ||
|
||
#define JOB_USCM_GROUND_CIVILIAN "Civilian Researcher" | ||
|
||
#define DEPARTMENT_USCM_GROUND_COMMAND | ||
#define DEPARTMENT_USCM_GROUND_SUPPORT | ||
#define DEPARTMENT_USCM_GROUND_MARINE | ||
Comment on lines
+158
to
+160
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you mean to keep the defines as nothing? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oversight and good catch. |
||
#define DEPARTMENT_USCM_GROUND_ALL list(\ | ||
"Outpost Command" = list(JOB_USCM_GROUND_CO, JOB_USCM_GROUND_AO),\ | ||
"Outpost Support" = list(JOB_USCM_GROUND_SYNTH),\ | ||
"Outpost Marine" = list(JOB_USCM_GROUND_SQUAD_LEADER, JOB_USCM_GROUND_SQUAD_TEAM_LEADER, JOB_USCM_GROUND_SQUAD_MEDIC, JOB_USCM_GROUND_SQUAD_SPECIALIST, JOB_USCM_GROUND_SQUAD_SMARTGUNNER, JOB_USCM_GROUND_SQUAD_MARINE),\ | ||
) | ||
|
||
//------------------------------------ | ||
|
||
//-------------WO roles--------------- | ||
|
||
#define JOB_WO_CO "Ground Commander" | ||
|
@@ -182,7 +196,6 @@ var/global/list/job_command_roles = JOB_COMMAND_ROLES_LIST | |
#define JOB_WO_SQUAD_SMARTGUNNER "Dust Raider Squad Smartgunner" | ||
#define JOB_WO_SQUAD_SPECIALIST "Dust Raider Squad Weapons Specialist" | ||
#define JOB_WO_SQUAD_LEADER "Dust Raider Squad Leader" | ||
|
||
//------------------------------------ | ||
|
||
//-------- PMC --------// | ||
|
@@ -193,7 +206,7 @@ var/global/list/job_command_roles = JOB_COMMAND_ROLES_LIST | |
#define JOB_PMC_INVESTIGATOR "PMC Medical Investigator" | ||
#define JOB_PMC_DETAINER "Weyland-Yutani PMC (Detainer)" | ||
#define JOB_PMC_ELITE "PMC Elite" | ||
#define JOB_PMC_GUNNER "PMC Support Weapons Specialist" //Renamed from Specialist to Support Specialist as it only has SG skills. | ||
#define JOB_PMC_GUNNER "PMC Smartgunner" //Renamed to Smartgunner. | ||
#define JOB_PMC_SNIPER "PMC Weapons Specialist" //Renamed from Sharpshooter to specialist as it uses specialist skills. | ||
#define JOB_PMC_CREWMAN "Weyland-Yutani PMC (Crewman)" | ||
#define JOB_PMC_NINJA "PMC Ninja" | ||
|
@@ -206,6 +219,13 @@ var/global/list/job_command_roles = JOB_COMMAND_ROLES_LIST | |
|
||
#define JOB_PMC_GRUNT_LIST list(JOB_PMC_STANDARD, JOB_PMC_ENGINEER, JOB_PMC_MEDIC, JOB_PMC_INVESTIGATOR, JOB_PMC_DETAINER, JOB_PMC_ELITE, JOB_PMC_GUNNER, JOB_PMC_SNIPER, JOB_PMC_CREWMAN, JOB_PMC_NINJA, JOB_PMC_XENO_HANDLER, JOB_PMC_COMMANDO, JOB_PMC_LEADER, JOB_PMC_LEAD_INVEST) | ||
|
||
#define DEPARTMENT_PMC_ALL list(\ | ||
"PMC Command" = list(JOB_PMC_DIRECTOR, JOB_PMC_LEAD_INVEST, JOB_PMC_LEADER),\ | ||
"PMC Elite" = list(JOB_PMC_COMMANDO, JOB_PMC_ELITE),\ | ||
"PMC Support" = list(JOB_PMC_DOCTOR, JOB_PMC_MEDIC, JOB_PMC_ENGINEER, JOB_PMC_INVESTIGATOR, JOB_PMC_CREWMAN, JOB_PMC_XENO_HANDLER, JOB_PMC_SYNTH),\ | ||
"PMC Combat" = list(JOB_PMC_STANDARD, JOB_PMC_GUNNER, JOB_PMC_SNIPER, JOB_PMC_NINJA),\ | ||
) | ||
|
||
//-------- WY --------// | ||
|
||
#define JOB_TRAINEE "Corporate Trainee" | ||
|
@@ -223,9 +243,17 @@ var/global/list/job_command_roles = JOB_COMMAND_ROLES_LIST | |
#define JOB_WY_GOON "WY Corporate Security" | ||
#define JOB_WY_GOON_LEAD "WY Corporate Security Lead" | ||
#define JOB_WY_GOON_RESEARCHER "WY Research Consultant" | ||
|
||
#define JOB_WY_GOON_LIST list(JOB_WY_GOON, JOB_WY_GOON_LEAD) | ||
|
||
#define DEPARTMENT_WY_ALL list(\ | ||
"WY Senior Management" = list(JOB_DIRECTOR, JOB_CHIEF_EXECUTIVE, JOB_DIVISION_MANAGER),\ | ||
"WY Middle Management" = list(JOB_ASSISTANT_MANAGER, JOB_EXECUTIVE_SUPERVISOR, JOB_EXECUTIVE_SPECIALIST, JOB_SENIOR_EXECUTIVE),\ | ||
"WY Junior Management" = list(JOB_EXECUTIVE, JOB_JUNIOR_EXECUTIVE, JOB_TRAINEE),\ | ||
"WY Security Team" = JOB_WY_GOON_LIST,\ | ||
) | ||
|
||
#define DEPARTMENT_WY_PMC_ALL (DEPARTMENT_WY_ALL + DEPARTMENT_PMC_ALL) | ||
|
||
//---- Contractors ----// | ||
#define JOB_CONTRACTOR "VAIPO Mercenary" | ||
#define JOB_CONTRACTOR_ST "VAIPO Mercenary" | ||
|
@@ -255,6 +283,15 @@ var/global/list/job_command_roles = JOB_COMMAND_ROLES_LIST | |
|
||
//-------- FORECON --------// | ||
|
||
//Platoon version | ||
#define JOB_SQUAD_TEAM_LEADER_FORECON "FORECON Assistant Squad Leader" | ||
#define JOB_SQUAD_LEADER_FORECON "FORECON Squad Leader" | ||
#define JOB_SQUAD_MEDIC_FORECON "FORECON Squad Corpsman" | ||
#define JOB_SQUAD_RTO "Radio Telephone Operator" | ||
#define JOB_SQUAD_MARINE_FORECON "FORECON Rifleman" | ||
#define JOB_SQUAD_SMARTGUN_FORECON "FORECON Smartgunner" | ||
|
||
//Regular faction | ||
#define JOB_FORECON_CO "Reconnaissance Commander" | ||
#define JOB_FORECON_SL "Reconnaissance Squad Leader" | ||
#define JOB_FORECON_SYN "Reconnaissance Synthetic" | ||
|
@@ -265,6 +302,16 @@ var/global/list/job_command_roles = JOB_COMMAND_ROLES_LIST | |
#define JOB_FORECON_SMARTGUNNER "Reconnaissance Smartgunner" | ||
|
||
//-------- UPP --------// | ||
|
||
//Platoon version | ||
#define JOB_SQUAD_MARINE_UPP "UPP Rifleman" | ||
#define JOB_SQUAD_LEADER_UPP "UPP Platoon Sergeant" | ||
#define JOB_SQUAD_MEDIC_UPP "UPP Sanitar" | ||
#define JOB_SQUAD_TEAM_LEADER_UPP "UPP Squad Sergeant" | ||
#define JOB_SQUAD_SMARTGUN_UPP "UPP Machinegunner" | ||
#define JOB_SO_UPP "UPP Platoon Commander" | ||
|
||
//Regular faction version | ||
#define JOB_UPP "UPP Private" | ||
#define JOB_UPP_CONSCRIPT "UPP Conscript" | ||
#define JOB_UPP_ENGI "UPP Korporal Sapper" | ||
|
@@ -299,6 +346,17 @@ var/global/list/job_command_roles = JOB_COMMAND_ROLES_LIST | |
|
||
#define JOB_UPP_CREWMAN "UPP Tank Crewman" | ||
|
||
|
||
#define DEPARTMENT_UPP_ALL list(\ | ||
"UPP Senior Kommand" = list(JOB_UPP_GENERAL, JOB_UPP_LT_GENERAL, JOB_UPP_MAY_GENERAL, JOB_UPP_KOL_OFFICER, JOB_UPP_LTKOL_OFFICER, JOB_UPP_MAY_OFFICER),\ | ||
"UPP Kommand" = list(JOB_UPP_KPT_OFFICER, JOB_UPP_SRLT_OFFICER, JOB_UPP_LT_OFFICER),\ | ||
"UPP Elite" = (UPP_COMMANDO_JOB_LIST + JOB_UPP_COMBAT_SYNTH),\ | ||
"UPP Support" = list(JOB_UPP_CREWMAN, JOB_UPP_SUPPORT_SYNTH, JOB_UPP_POLICE, JOB_UPP_LT_DOKTOR),\ | ||
"UPP Kombat" = list(JOB_UPP_LEADER, JOB_UPP_SPECIALIST, JOB_UPP_MEDIC, JOB_UPP_ENGI, JOB_UPP),\ | ||
"UPP Platoon" = list(JOB_SQUAD_MARINE_UPP, JOB_SQUAD_LEADER_UPP, JOB_SQUAD_MEDIC_UPP, JOB_SQUAD_TEAM_LEADER_UPP, JOB_SQUAD_SMARTGUN_UPP, JOB_SO_UPP),\ | ||
"UPP Diplomatic" = list(JOB_UPP_REPRESENTATIVE),\ | ||
) | ||
|
||
//-------- CLF --------// | ||
#define JOB_CLF "CLF Guerilla" | ||
#define JOB_CLF_ENGI "CLF Field Technician" | ||
|
@@ -385,16 +443,17 @@ var/global/list/job_command_roles = JOB_COMMAND_ROLES_LIST | |
#define JOB_OBSERVER "Observer" | ||
#define TIMELOCK_JOB(role_id, hours) new/datum/timelock(role_id, hours, role_id) | ||
|
||
//For displaying groups of jobs. Used by new player's latejoin menu and by crew manifest. | ||
#define FLAG_SHOW_CIC 1 | ||
#define FLAG_SHOW_AUXIL_SUPPORT 2 | ||
#define FLAG_SHOW_MISC 4 | ||
#define FLAG_SHOW_POLICE 8 | ||
#define FLAG_SHOW_ENGINEERING 16 | ||
#define FLAG_SHOW_REQUISITION 32 | ||
#define FLAG_SHOW_MEDICAL 64 | ||
#define FLAG_SHOW_MARINES 128 | ||
#define FLAG_SHOW_ALL_JOBS FLAG_SHOW_CIC|FLAG_SHOW_AUXIL_SUPPORT|FLAG_SHOW_MISC|FLAG_SHOW_POLICE|FLAG_SHOW_ENGINEERING|FLAG_SHOW_REQUISITION|FLAG_SHOW_MEDICAL|FLAG_SHOW_MARINES | ||
/// Job categories, for the crew manifest and late joining. Replaces the flags that were previously used. | ||
#define JOB_CATEGORY_OTHER "Other / RP" | ||
#define JOB_CATEGORY_CIC "Command" | ||
#define JOB_CATEGORY_SUPPORT "Auxiliary Support" | ||
#define JOB_CATEGORY_POLICE "Law Enforcement" | ||
#define JOB_CATEGORY_ENGINEERING "Engineering" | ||
#define JOB_CATEGORY_REQUISITION "Requisitions" | ||
#define JOB_CATEGORY_MEDICAL "Medical" | ||
#define JOB_CATEGORY_COMBAT "Combat" | ||
//This list allows us to keep all manifest categories in the same order every time, regardless of who spawned when/first/second/third. | ||
#define JOB_CATEGORY_ALL list(JOB_CATEGORY_CIC, JOB_CATEGORY_SUPPORT, JOB_CATEGORY_POLICE, JOB_CATEGORY_ENGINEERING, JOB_CATEGORY_REQUISITION, JOB_CATEGORY_MEDICAL, JOB_CATEGORY_COMBAT, JOB_CATEGORY_OTHER) | ||
|
||
///For denying certain traits being applied to people. ie. bad leg | ||
///'Grunt' lists are for people who wouldn't logically get the bad leg trait, ie. UPP marine counterparts. | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this became the define when its only going to be used in 1-2 places when theres tons of places that use
SSmapping.configs[GROUND_MAP].map_name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used in three instances across three different files. It is easier to find and change this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once made into a global proc it'll likely only be used in one place. And as I said the more suitable one to become a define is
SSmapping.configs[GROUND_MAP].map_name
but that will touch a lot of files - though that hasn't stopped you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on a convo with harryob, I'm starting to think it may be better to revert my changes and create better integration for map items via json files. Something to come back to.