-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SA .357 Swap #187
SA .357 Swap #187
Conversation
hm yes comically powerful .357 |
//MARINE REVOLVER //Spearhead exists in Alien cannon, this one is based on the Dark Descent model. | ||
|
||
/obj/item/weapon/gun/revolver/cmb/marine | ||
name = "\improper SA .357" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "\improper SA .357" | |
name = "\improper .357 SA autorevolver" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SA stands for "Spearhead Autorevolver" so I don't think putting a second Autorevolver in the title is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I'm just basing it on Dark Descent, which also calls the revolver "SA .357 Revolver". I can take on Revolver at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait it ISN'T Single Action .357? Topkek.
was told to comment here, i dont really see this as a needed change, it feels like a change for the sake of change rather than something that actually impacts anything. i cant exactly say im a fan of the sprite either, it doesnt look as nice and refined as the current .44 sprite. |
codersprite in standard issue gives me pain |
As said, it's to replace the made-up M44 revolver from CM with a revolver that is actually from the setting and shown to be used by the Marines. The sprite is just a color swapped version of the CMB already in the game (with a slight silhouette change at the front to better match the pistol model). Considering other weapons have been swapped out by Morrow himself to keep in tune with the setting, such as the M41A Mk1 replacing the Mk2, I wouldn't say it is at all fair to propose adding the Marine service SA .357 is "change for the sake of change". Just like the previous mention of the damage provided to normalpoint ammo, also I do not see how personal preference for sprite quality would bar a PR when the weapon its based on is already in the game and very present on the maps. There is a proposed new sprite in the CM discord, but I have no way of contacting the guy who made it for permission to use here. |
Adds the new SA .357 autorevolver to Marine armories, replacing the M44 for a lore friendly option. Has an altered CMB sprite based on its Dark Descent variation, and comes with regular ammo rather than the hollow point that the CMB gets. Also ups the damage on the regular ammo to be in line with the M44, to avoid an ill felt balance difference.