-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M44 sprite and sound changes #196
Conversation
imagine NOT crediting the sprote author |
No clue what youre talking about mr jeremy loyd! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, I like the other sound better.
Also make sure to credit the sprite author in the PR description please.
They are credited. What sound, firing? |
Yeah |
If Amory's pull request (that changes the wooden palette for the Shotgun and Revolver) ends up being merged, let me know and I'll send a color-corrected version of this .dmi. |
commit 6392549 Merge: 5c27cc6 72a1e3f Author: AmoryBlaine <[email protected]> Date: Tue Apr 9 23:38:50 2024 -0400 Merge branch 'PvE-CMSS13:master' into master commit 72a1e3f Author: KoishiVibe <[email protected]> Date: Tue Apr 9 21:04:11 2024 -0500 more fluff, removes kevlar mentions and replaces with venlar (cmss13-devs#188) Co-authored-by: KoishiVibe <[email protected]> Co-authored-by: morrowwolf <[email protected]> commit 0c61b76 Author: DexterDude <[email protected]> Date: Tue Apr 9 21:24:46 2024 -0400 M44 sprite and sound changes (cmss13-devs#196) commit 4475857 Author: morrowwolf <[email protected]> Date: Tue Apr 9 21:22:51 2024 -0400 Medals (cmss13-devs#222) commit 4020295 Author: grifp71 <[email protected]> Date: Tue Apr 9 21:22:20 2024 -0400 Biblically Accurate Smartguns (cmss13-devs#213) Co-authored-by: morrow <[email protected]> commit 5c27cc6 Merge: 298847c 0976be2 Author: AmoryBlaine <[email protected]> Date: Mon Apr 8 17:13:21 2024 -0400 Merge branch 'PvE-CMSS13:master' into master commit 0976be2 Author: AndroBetel <[email protected]> Date: Mon Apr 8 23:30:12 2024 +0300 machetes now have belt slot sprites (cmss13-devs#224) Fix for a previously invisible belt scabbard. commit 1a5b544 Author: grifp71 <[email protected]> Date: Sun Apr 7 19:15:10 2024 -0400 Machetes on back for smartgunners (cmss13-devs#177) commit 784a01f Author: AmoryBlaine <[email protected]> Date: Sat Apr 6 19:00:35 2024 -0400 Fixes horizontal access denied sprite (cmss13-devs#218) Horizontal fix. commit c91382d Author: Nihisohel <[email protected]> Date: Sun Apr 7 00:03:12 2024 +0800 Tactical reload on the move (cmss13-devs#217)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> # About the pull request imports the m44 sprites from downstream (PvE) cmss13-devs/cmss13-pve#196 <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game They look more organic and "real" than the current thin revolver sprites <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding, and may discourage maintainers from reviewing or merging your PR. This section is not strictly required for (non-controversial) fix PRs or backend PRs. --> # Testing Photographs and Procedure <!-- Include any screenshots/videos/debugging steps of the modified code functioning successfully, ideally including edge cases. --> <!-- !! If you are modifying sprites, you **must** include one or more in-game screenshots or videos of the new sprites. !! --> <details> <summary>Screenshots & Videos</summary> ![bBTneUK3Bq](https://github.com/user-attachments/assets/a5825f72-6d8b-48ef-80a2-7b67a341112b) </details> # Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly label your changes in the changelog. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> <!-- If you add a name after the ':cl', that name will be used in the changelog. You must add your CKEY after the CL if your GitHub name doesn't match. Maintainers freely reserve the right to remove and add tags should they deem it appropriate. --> :cl: dongwaiver imageadd: new m44 revolver sprites imagedel: old m44 revolver sprites /:cl: <!-- Both :cl:'s are required for the changelog to work! -->
Changes the sprites and sounds of the M44 revolver to make it sound and look a little more beefy overall. Before it sounded a little flat and the audio for most of its sounds was very...meh and flat in my opinion. The UPP revolver sounds are far better, though I'd appreciate input.
The sprites changed simply make it a little more beefy.
Credit to dongwaiver on discord for the sprites, i just added them
2024-03-30.03-53-59.mp4