Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMARTGUN BUFF #202

Closed
wants to merge 55 commits into from
Closed

SMARTGUN BUFF #202

wants to merge 55 commits into from

Conversation

Kirshbia
Copy link
Contributor

@Kirshbia Kirshbia commented Apr 1, 2024

About the pull request

Sadly, I may or may not of deleted my initial very fun project making the SG take all ammo types when I did a fresh windows install.

HOWEVER, I think in essence this should capture what I was going for and lay the groundwork for a future project with the CO smartgun for PVE.

It carries a slight damage increase for SG's in AP mode as well as grants their regular rounds HOLO targeting effects which I think will help affirm them in the fire support category and let them feel cool when firing off those guns.

Explain why it's good for the game

It's a small damage buff increase to SG's as well as adding a feature that will help solidify team play. When monkey brain see's yellow aura showing hit with holo I am hoping all neurons fire off and everyone moves to focus fire. The damage increase isn't too noticeable and I think it'll make the SG feel better to use.

Changelog

🆑
balance: Changed the SG's base auto type to HOLO rounds. Increased damage on AP rounds.
/:cl:

@Kirshbia
Copy link
Contributor Author

Kirshbia commented Apr 1, 2024

Small increase to damage as i believe the default SG datam is where the APC/M56 tank take their damage from.

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me think about this one, default holo is pretty strong.

Also, you should really learn how to use branches as working off your master branch is generally a bad idea and creates the vomit of commits you see above there.

@morrowwolf morrowwolf marked this pull request as draft April 1, 2024 17:09
@Kirshbia
Copy link
Contributor Author

Kirshbia commented Apr 1, 2024

Let me think about this one, default holo is pretty strong.

Also, you should really learn how to use branches as working off your master branch is generally a bad idea and creates the vomit of commits you see above there.

Oh, for sure. On stand alone testing it wasn't too noticeable of a difference. I totally want to actually see what it would result in practical gameplay.

Copy link
Contributor

@AndroBetel AndroBetel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't really like holorounds, as they feel too "gamey" with blue aura and increased damage for friendlies

if anything, just buff smartguns damage if it feels too weak

@FslashN
Copy link
Contributor

FslashN commented Apr 4, 2024

Holy commits, Batman! But yeah, what Andro stated. Getting rid of the toggle and upping the damage; the toggle doesn't make any logical or lore sense anyway.

Edit: Andro pointed me to the Technical Manual which actually does list the (fuze) selector (you're not actually shooting different rounds, but selecting when they detonate). It's all weird space magic science engineering, but it is lore. Maybe just buff the damage on each round type.

Edit x2: Alternative idea. Buff the smartgun damage to lore levels, disallow carrying ammo in belts/pouches. Someone else will need to carry it in a backpack or by hand if you want more. Would be an interesting thing to test out.

@morrowwolf
Copy link
Member

I just don't really like holo rounds sadly. The other PR buffing smartgunners is definitely cooking though so soonTM smartgunners will get some love.

@morrowwolf morrowwolf closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants