Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emote and talking length #244

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

bearrrrrrrr
Copy link
Contributor

About the pull request

increases emote/say length. it was capped rly low for some reason. 256 is really not a whole lot of characters. this is already 131.

Explain why it's good for the game

RP...good

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: emote length
/:cl:

@DexterDude
Copy link
Contributor

rp bad

@KoishiVibe
Copy link
Contributor

rp bad

failrp
admemes ban he

@@ -119,8 +119,8 @@ var/list/AAlarmIndexToWireColor
var/list/AAlarmWireColorToIndex

//Don't set this very much higher then 1024 unless you like inviting people in to dos your server with message spam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno about this one. 2048 character emotes, for what exactly?

Copy link
Contributor

@FslashN FslashN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are good reasons for having a message limit, and I don't know that having huge-large emote length is a good thing, either. Text already takes a while to render when you're speaking large sections of it.

@Skycave1
Copy link

Skycave1 commented Apr 23, 2024

The default SS13 message limit is 2056, and CM back in it's hayday ran fine with the default limits in play. I've noticed whenever you play on a server with a character limit higher than the default is when things start to chug, and that's generally on servers hosting more than 20 people at a time on top of extending the character limit with some spaghetti code so the game doesn't have a stroke. Plus we have green shift and having your message cut off because of a limit as comically low as 256 is just bad for practice and stifles certain avenues of RP. Maybe I left CM and changed, but some great stories came out of CM back in 2014/15 because of said character limit. Albeit rare, it was always fun to see

And I wanna spite Aero and Columbo post (4k character me;) just to make them angy.

@bearrrrrrrr
Copy link
Contributor Author

There are good reasons for having a message limit, and I don't know that having huge-large emote length is a good thing, either. Text already takes a while to render when you're speaking large sections of it.

256 characters for an emote length is pretty low. 2048 was a random, arbitrary number I picked. I can put it at par w/ say, if that's better for you. I don't really mind- I'm probably just an outlier, but I have actually genuinely had my emotes cut off.

^ This is above the emote limit, by the way

@bearrrrrrrr
Copy link
Contributor Author

To add on; in most normal rounds, it doesn't matter. In greenshifts, it hurts a lil, and I think (iirc) it has happened to people other than just me.

@Skycave1
Copy link

To add on; in most normal rounds, it doesn't matter. In greenshifts, it hurts a lil, and I think (iirc) it has happened to people other than just me.

I think a limit of 2k is good, but that is just my dumb ass, and it is bellow the default cap as it is. Dare we spaghetti code a 4k character limit?

@morrowwolf
Copy link
Member

1024 is more than enough, let's leave it there. It is one of my stronger opinions that RP should be back and forth rather than thrust upon someone else and responding sentence by sentence makes it easier to engage in a back and forth rather than paragraphing at each other awkwardly (which I find to be unrealistic but maybe that's just because I'm ADHD and can't stand conversations that slow).

@morrowwolf morrowwolf merged commit 2c907d2 into cmss13-devs:master Apr 24, 2024
35 checks passed
@bearrrrrrrr
Copy link
Contributor Author

1024 is more than enough, let's leave it there. It is one of my stronger opinions that RP should be back and forth rather than thrust upon someone else and responding sentence by sentence makes it easier to engage in a back and forth rather than paragraphing at each other awkwardly (which I find to be unrealistic but maybe that's just because I'm ADHD and can't stand conversations that slow).

nah this is also true

one of my biggest pet peeves on ss13 is someone dropping 5 paragraphs on me at once as i stand there awkwardly staring lmao

AndroBetel pushed a commit to kirieee/PvE-CMSS13 that referenced this pull request Jun 1, 2024
AndroBetel pushed a commit to kirieee/PvE-CMSS13 that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants