GM Sound Panel [WIP] #255
Merged
GM Sound Panel [WIP] #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doubleumc
added
needs tested
|
Might be worth having client stored favorites |
can set local sounds to play on click instead of needing a separate click, needed to move data storage to the datum as a consequence
filtering updated *after* the render, leaving the browser one render behind, now fixed
morrowwolf
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Implements a GM panel that allows playing of ingame sounds.
Searchable list of all sound files in the codebase. Adjust sound category, volume, pitch, duration, and preview the sound at those settings. Can play sounds to only a single client (in their head, basically), as a localized sound, to everyone on a z-level, or to all humans/ghosts/xenos/globally on the server.
Currently a work-in-progress, can be test-merged but NOT ready for full merge. Needs to be tested and need feedback on the UX.
Explain why it's good for the game
More versatile tools for GMs to set the scene.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: GM panel with sound controls
/:cl: