Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATTACHMENT FLAVOR TEXT GO #276

Merged
merged 23 commits into from
Aug 17, 2024

Conversation

KoishiVibe
Copy link
Contributor

Summary

new year new flavor text
also includes UPP variants for most of the attachments (cosmetic)

Explain why it's good for the game

muh immersion

@KoishiVibe KoishiVibe marked this pull request as ready for review June 2, 2024 15:47
@KoishiVibe
Copy link
Contributor Author

it should be ready technically.

code/modules/projectiles/gun_attachables.dm Outdated Show resolved Hide resolved
code/modules/projectiles/gun_attachables.dm Show resolved Hide resolved
@AndroBetel
Copy link
Contributor

upp attachies could also use some custom sprites ig... to fit the theme better... but mostly whatever...

@AndroBetel AndroBetel marked this pull request as draft June 5, 2024 12:31
@KoishiVibe KoishiVibe marked this pull request as ready for review June 13, 2024 20:08
Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtype them as upp instead of union, for example: /obj/item/attachable/angledgrip/upp instead of /obj/item/attachable/angledgrip/union

Everything else UPP is typed upp, these should be as well.

@KoishiVibe
Copy link
Contributor Author

Subtype them as upp instead of union, for example: /obj/item/attachable/angledgrip/upp instead of /obj/item/attachable/angledgrip/union

Everything else UPP is typed upp, these should be as well.

Done.

@Doubleumc Doubleumc dismissed AndroBetel’s stale review August 13, 2024 07:04

requested changes complete

@Doubleumc Doubleumc merged commit cf4b576 into cmss13-devs:master Aug 17, 2024
35 checks passed
@KoishiVibe KoishiVibe deleted the attachments-flavor-textinator branch September 16, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants